Closed Bug 1900670 Opened 1 year ago Closed 1 year ago

Update libjxl to new version ba1bfac861315803dc53888abddca8f665c8edf3 from 2024-06-04 13:15:38

Categories

(Core :: Graphics: ImageLib, enhancement)

Product:
Core
Component:
Graphics: ImageLib
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
128 Branch
Tracking Flags:
Tracking Status
firefox128 --- fixed

People

(Reporter: update-bot, Assigned: saschanaz)

References

Details

(Whiteboard: [3pl-filed][task_id: b0k-6tzASrWkM8Nc3utBew])

Attachments

(1 file)

Bug 1900670 - Update libjxl to ba1bfac861315803dc53888abddca8f665c8edf3
48 bytes, text/x-phabricator-request
Details | Review

This update covers 26 commits. Here are the overall diff statistics, and then the commit information.

media/libjxl/moz.build | 2 +-
media/libjxl/moz.yaml | 4 +-
third_party/jpeg-xl/.clang-tidy | 5 +-
third_party/jpeg-xl/AUTHORS | 1 +
third_party/jpeg-xl/CMakeLists.txt | 15 +-
third_party/jpeg-xl/ci.sh | 137 +++--
third_party/jpeg-xl/lib/extras/dec/apng.cc | 7 +-
third_party/jpeg-xl/lib/extras/dec/exr.cc | 4 +-
third_party/jpeg-xl/lib/extras/dec/gif.cc | 2 +-
third_party/jpeg-xl/lib/extras/dec/jxl.cc | 15 +-
third_party/jpeg-xl/lib/extras/dec/jxl.h | 7 +-
third_party/jpeg-xl/lib/extras/dec/pgx_test.cc | 6 +
third_party/jpeg-xl/lib/extras/dec/pnm.cc | 2 +-
third_party/jpeg-xl/lib/extras/enc/apng.cc | 10 +-
third_party/jpeg-xl/lib/extras/enc/jpg.cc | 2 +-
third_party/jpeg-xl/lib/extras/enc/jxl.cc | 20 +-
third_party/jpeg-xl/lib/extras/enc/jxl.h | 17 +-
third_party/jpeg-xl/lib/extras/enc/pnm.cc | 2 +-
third_party/jpeg-xl/lib/extras/gain_map.cc | 230 ++++++++++
third_party/jpeg-xl/lib/extras/gain_map_test.cc | 190 ++++++++
third_party/jpeg-xl/lib/extras/packed_image.h | 1 +
third_party/jpeg-xl/lib/extras/packed_image_convert.cc | 4 +-
third_party/jpeg-xl/lib/extras/time.cc | 2 +-
third_party/jpeg-xl/lib/extras/tone_mapping_gbench.cc | 1 +
third_party/jpeg-xl/lib/include/jxl/cms_interface.h | 4 +-
third_party/jpeg-xl/lib/include/jxl/codestream_header.h | 4 +-
third_party/jpeg-xl/lib/include/jxl/color_encoding.h | 4 +-
third_party/jpeg-xl/lib/include/jxl/decode.h | 4 +-
third_party/jpeg-xl/lib/include/jxl/decode_cxx.h | 2 +-
third_party/jpeg-xl/lib/include/jxl/encode.h | 4 +-
third_party/jpeg-xl/lib/include/jxl/encode_cxx.h | 2 +-
third_party/jpeg-xl/lib/include/jxl/gain_map.h | 129 +++++
third_party/jpeg-xl/lib/include/jxl/memory_manager.h | 4 +-
third_party/jpeg-xl/lib/include/jxl/parallel_runner.h | 4 +-
third_party/jpeg-xl/lib/include/jxl/resizable_parallel_runner.h | 4 +-
third_party/jpeg-xl/lib/include/jxl/resizable_parallel_runner_cxx.h | 2 +-
third_party/jpeg-xl/lib/include/jxl/stats.h | 4 +-
third_party/jpeg-xl/lib/include/jxl/thread_parallel_runner.h | 4 +-
third_party/jpeg-xl/lib/include/jxl/thread_parallel_runner_cxx.h | 2 +-
third_party/jpeg-xl/lib/include/jxl/types.h | 4 +-
third_party/jpeg-xl/lib/jpegli/adaptive_quantization.cc | 8 +-
third_party/jpeg-xl/lib/jpegli/common.h | 4 +-
third_party/jpeg-xl/lib/jpegli/common_internal.h | 17 +
third_party/jpeg-xl/lib/jpegli/dct-inl.h | 32 +-
third_party/jpeg-xl/lib/jpegli/decode.h | 4 +-
third_party/jpeg-xl/lib/jpegli/decode_internal.h | 2 +-
third_party/jpeg-xl/lib/jpegli/downsample.cc | 9 +-
third_party/jpeg-xl/lib/jpegli/encode.cc | 4 +-
third_party/jpeg-xl/lib/jpegli/encode.h | 4 +-
third_party/jpeg-xl/lib/jpegli/encode_finish.cc | 10 +-
third_party/jpeg-xl/lib/jpegli/encode_streaming.cc | 6 +-
third_party/jpeg-xl/lib/jpegli/entropy_coding.cc | 14 +-
third_party/jpeg-xl/lib/jpegli/error.cc | 2 +-
third_party/jpeg-xl/lib/jpegli/error_handling_test.cc | 4 +-
third_party/jpeg-xl/lib/jpegli/fuzztest.h | 22 +
third_party/jpeg-xl/lib/jpegli/idct.cc | 15 +-
third_party/jpeg-xl/lib/jpegli/libjpeg_test_util.cc | 5 +
third_party/jpeg-xl/lib/jpegli/render.cc | 12 +-
third_party/jpeg-xl/lib/jpegli/streaming_test.cc | 33 +-
third_party/jpeg-xl/lib/jpegli/test_utils-inl.h | 6 +-
third_party/jpeg-xl/lib/jpegli/test_utils.cc | 4 +-
third_party/jpeg-xl/lib/jpegli/test_utils.h | 12 -
third_party/jpeg-xl/lib/jpegli/types.h | 4 +-
third_party/jpeg-xl/lib/jxl/ac_strategy.cc | 4 +-
third_party/jpeg-xl/lib/jxl/ans_test.cc | 2 +-
third_party/jpeg-xl/lib/jxl/base/compiler_specific.h | 11 +
third_party/jpeg-xl/lib/jxl/base/scope_guard.h | 3 +-
third_party/jpeg-xl/lib/jxl/bit_reader_test.cc | 3 +
third_party/jpeg-xl/lib/jxl/butteraugli/butteraugli_test.cc | 27 +-
third_party/jpeg-xl/lib/jxl/cache_aligned.cc | 159 ------
third_party/jpeg-xl/lib/jxl/cache_aligned.h | 65 --
third_party/jpeg-xl/lib/jxl/chroma_from_luma.cc | 32 +-
third_party/jpeg-xl/lib/jxl/chroma_from_luma.h | 68 +-
third_party/jpeg-xl/lib/jxl/cms/jxl_cms_internal.h | 9 +-
third_party/jpeg-xl/lib/jxl/cms/tone_mapping_test.cc | 6 +-
third_party/jpeg-xl/lib/jxl/cms/transfer_functions-inl.h | 36 +-
third_party/jpeg-xl/lib/jxl/codec_in_out.h | 2 +
third_party/jpeg-xl/lib/jxl/coeff_order.h | 2 +-
third_party/jpeg-xl/lib/jxl/coeff_order_test.cc | 6 +-
third_party/jpeg-xl/lib/jxl/color_management_test.cc | 1 +
third_party/jpeg-xl/lib/jxl/convolve-inl.h | 3 +-
third_party/jpeg-xl/lib/jxl/convolve_test.cc | 1 +
third_party/jpeg-xl/lib/jxl/dct-inl.h | 48 +-
third_party/jpeg-xl/lib/jxl/dct_scales.cc | 5 +-
third_party/jpeg-xl/lib/jxl/dec_ans.cc | 28 +-
third_party/jpeg-xl/lib/jxl/dec_ans.h | 9 +-
third_party/jpeg-xl/lib/jxl/dec_cache.cc | 20 +-
third_party/jpeg-xl/lib/jxl/dec_context_map.cc | 3 +
third_party/jpeg-xl/lib/jxl/dec_context_map.h | 4 +-
third_party/jpeg-xl/lib/jxl/dec_external_image_gbench.cc | 1 +
third_party/jpeg-xl/lib/jxl/dec_frame.cc | 29 +-
third_party/jpeg-xl/lib/jxl/dec_group.cc | 14 +-
third_party/jpeg-xl/lib/jxl/dec_group.h | 2 +-
third_party/jpeg-xl/lib/jxl/dec_group_border.cc | 2 +-
third_party/jpeg-xl/lib/jxl/dec_group_border.h | 4 +-
third_party/jpeg-xl/lib/jxl/dec_modular.cc | 2 +-
third_party/jpeg-xl/lib/jxl/dec_noise.cc | 42 +-
third_party/jpeg-xl/lib/jxl/dec_noise.h | 14 +-
third_party/jpeg-xl/lib/jxl/dec_patch_dictionary.cc | 46 +-
third_party/jpeg-xl/lib/jxl/dec_patch_dictionary.h | 29 +-
third_party/jpeg-xl/lib/jxl/decode.cc | 30 +-
third_party/jpeg-xl/lib/jxl/decode_test.cc | 82 +--
third_party/jpeg-xl/lib/jxl/enc_ac_strategy.cc | 6 +-
third_party/jpeg-xl/lib/jxl/enc_adaptive_quantization.cc | 18 +-
third_party/jpeg-xl/lib/jxl/enc_bit_writer.h | 1 +
third_party/jpeg-xl/lib/jxl/enc_cache.cc | 3 +-
third_party/jpeg-xl/lib/jxl/enc_chroma_from_luma.cc | 16 +-
third_party/jpeg-xl/lib/jxl/enc_chroma_from_luma.h | 5 +-
third_party/jpeg-xl/lib/jxl/enc_coeff_order.cc | 17 +
third_party/jpeg-xl/lib/jxl/enc_dot_dictionary.cc | 21 +-
third_party/jpeg-xl/lib/jxl/enc_dot_dictionary.h | 2 +-
third_party/jpeg-xl/lib/jxl/enc_external_image_gbench.cc | 1 +
third_party/jpeg-xl/lib/jxl/enc_external_image_test.cc | 2 +-
third_party/jpeg-xl/lib/jxl/enc_fast_lossless.cc | 30 +-
third_party/jpeg-xl/lib/jxl/enc_fast_lossless.h | 4 +-
third_party/jpeg-xl/lib/jxl/enc_frame.cc | 22 +-
third_party/jpeg-xl/lib/jxl/enc_gaborish.cc | 5 +-
third_party/jpeg-xl/lib/jxl/enc_gaborish_test.cc | 1 +
third_party/jpeg-xl/lib/jxl/enc_group.cc | 14 +-
third_party/jpeg-xl/lib/jxl/enc_heuristics.cc | 35 +-
third_party/jpeg-xl/lib/jxl/enc_huffman_tree.cc | 17 +
third_party/jpeg-xl/lib/jxl/enc_modular.cc | 16 +-
third_party/jpeg-xl/lib/jxl/enc_params.h | 2 +-
third_party/jpeg-xl/lib/jxl/enc_patch_dictionary.cc | 31 +-
third_party/jpeg-xl/lib/jxl/enc_patch_dictionary.h | 4 +-
third_party/jpeg-xl/lib/jxl/encode.cc | 12 +-
third_party/jpeg-xl/lib/jxl/encode_internal.h | 8 +-
third_party/jpeg-xl/lib/jxl/encode_test.cc | 1 +
third_party/jpeg-xl/lib/jxl/entropy_coder.cc | 3 +
third_party/jpeg-xl/lib/jxl/entropy_coder.h | 1 +
third_party/jpeg-xl/lib/jxl/fast_math_test.cc | 2 +-
third_party/jpeg-xl/lib/jxl/fields_test.cc | 2 +-
third_party/jpeg-xl/lib/jxl/fuzztest.h | 22 +
third_party/jpeg-xl/lib/jxl/gradient_test.cc | 3 +
third_party/jpeg-xl/lib/jxl/icc_codec_test.cc | 4 +
third_party/jpeg-xl/lib/jxl/image.cc | 20 +-
third_party/jpeg-xl/lib/jxl/image.h | 32 +-
third_party/jpeg-xl/lib/jxl/image_bundle_test.cc | 5 +
third_party/jpeg-xl/lib/jxl/image_metadata.cc | 2 +
third_party/jpeg-xl/lib/jxl/image_ops_test.cc | 27 +-
third_party/jpeg-xl/lib/jxl/jpeg/dec_jpeg_output_chunk.h | 6 +-
third_party/jpeg-xl/lib/jxl/jpeg/enc_jpeg_data.cc | 4 +-
third_party/jpeg-xl/lib/jxl/jpeg/enc_jpeg_data.h | 1 +
third_party/jpeg-xl/lib/jxl/jxl_test.cc | 32 +-
third_party/jpeg-xl/lib/jxl/memory_manager_internal.cc | 138 +++++-
third_party/jpeg-xl/lib/jxl/memory_manager_internal.h | 92 ++-
third_party/jpeg-xl/lib/jxl/modular/encoding/enc_ma.cc | 35 +-
third_party/jpeg-xl/lib/jxl/modular/transform/squeeze.cc | 2 +
third_party/jpeg-xl/lib/jxl/modular_test.cc | 2 +
third_party/jpeg-xl/lib/jxl/opsin_image_test.cc | 2 +-
third_party/jpeg-xl/lib/jxl/opsin_inverse_test.cc | 1 +
third_party/jpeg-xl/lib/jxl/padded_bytes.h | 26 +-
third_party/jpeg-xl/lib/jxl/padded_bytes_test.cc | 3 +
third_party/jpeg-xl/lib/jxl/passes_state.cc | 2 +-
third_party/jpeg-xl/lib/jxl/passes_state.h | 17 +-
third_party/jpeg-xl/lib/jxl/passes_test.cc | 8 +-
third_party/jpeg-xl/lib/jxl/patch_dictionary_internal.h | 3 -
third_party/jpeg-xl/lib/jxl/patch_dictionary_test.cc | 1 +
third_party/jpeg-xl/lib/jxl/preview_test.cc | 1 +
third_party/jpeg-xl/lib/jxl/quant_weights.cc | 4 +-
third_party/jpeg-xl/lib/jxl/quant_weights_test.cc | 2 +-
third_party/jpeg-xl/lib/jxl/quantizer.cc | 2 +
third_party/jpeg-xl/lib/jxl/quantizer_test.cc | 2 +-
third_party/jpeg-xl/lib/jxl/render_pipeline/render_pipeline_test.cc | 6 +-
third_party/jpeg-xl/lib/jxl/render_pipeline/simple_render_pipeline.cc | 2 +-
third_party/jpeg-xl/lib/jxl/render_pipeline/stage_noise.cc | 19 +-
third_party/jpeg-xl/lib/jxl/render_pipeline/stage_noise.h | 2 +-
third_party/jpeg-xl/lib/jxl/render_pipeline/stage_patches.cc | 24 +-
third_party/jpeg-xl/lib/jxl/render_pipeline/stage_patches.h | 9 +-
third_party/jpeg-xl/lib/jxl/render_pipeline/stage_tone_mapping.cc | 4 +-
third_party/jpeg-xl/lib/jxl/render_pipeline/stage_write.cc | 39 +-
third_party/jpeg-xl/lib/jxl/render_pipeline/test_render_pipeline_stages.h | 8 +-
third_party/jpeg-xl/lib/jxl/roundtrip_test.cc | 30 +-
third_party/jpeg-xl/lib/jxl/simd_util.cc | 37 -
third_party/jpeg-xl/lib/jxl/simd_util.h | 7 +-
third_party/jpeg-xl/lib/jxl/splines.cc | 12 +-
third_party/jpeg-xl/lib/jxl/splines.h | 2 +-
third_party/jpeg-xl/lib/jxl/splines_gbench.cc | 11 +-
third_party/jpeg-xl/lib/jxl/splines_test.cc | 15 +-
third_party/jpeg-xl/lib/jxl/test_memory_manager.cc | 24 +
third_party/jpeg-xl/lib/jxl/test_memory_manager.h | 19 +
third_party/jpeg-xl/lib/jxl/test_utils.cc | 87 +++-
third_party/jpeg-xl/lib/jxl/test_utils.h | 22 +-
third_party/jpeg-xl/lib/jxl/toc_test.cc | 4 +
third_party/jpeg-xl/lib/jxl_lists.bzl | 9 +-
third_party/jpeg-xl/lib/jxl_lists.cmake | 9 +-
third_party/jpeg-xl/plugins/gimp/file-jxl-load.cc | 6 +-
187 files changed, 2024 insertions(+), 1140 deletions(-)

ba1bfac861315803dc53888abddca8f665c8edf3 by Moritz Firsching <firsching@google.com>

https://github.com/libjxl/libjxl/commit/ba1bfac861315803dc53888abddca8f665c8edf3
Authored: 2024-06-04 15:15:38 +0200
Committed: 2024-06-04 13:15:38 +0000

add jhgm box and basic gain map support (#3552)

  • add jhgm box

  • wip

Co-authored-by: Sami Boukortt <sboukortt@google.com>

  • move to extras

  • wip2

Co-authored-by: Sami Boukortt <sboukortt@google.com>

  • decompress icc

  • decompress icc also when writing

  • use correct endianness

  • documentation

  • mv GetIccTestProfile

  • cleanup

  • Memory manager, error handling

  • extern "C"

  • Newline at end of file

  • More error management

  • build_cleaner

  • No designated initializers

  • Correct export header now that this is not a separate library

  • change has_color_encoding to color_encoding_size

  • properly compress color encoding, similar to icc

  • remove gain_map_size

  • replace visitor for writer

  • replace visitor for reader

  • remove internal bundle

  • lint

  • use byte_order.h

  • add golden test

  • parametrized tests

  • fix test

  • fix includes

  • add test for JxlGainMapReadBundle

  • lint

  • compressed icc in gain map bundle

  • restructure reading the bundle

  • change color encoding size type

  • remove TODO

  • Bespoke memory manager for the gain map API

  • Only copy one byte from uint8_t

  • use SafeAdd

  • return JXL_FALSE

  • check reads within bounds

  • actually throw errors with SafeAdd

  • also return errors in JxlGainMapReadBundle

  • use CanEncode

  • use LoadBE and StoreBE

  • add struct docstring

  • move documention back to fields

  • Static functions

  • Macros

  • Remove accidental semicolon (its absence being the entire point of the do-while)

  • Remove leftover file

  • no more swap

  • rename ADVANCE_CURSOR

  • comment about underflow

Co-authored-by: Sami Boukortt <sboukortt@google.com>

Files Added:

  • lib/extras/gain_map.cc
  • lib/extras/gain_map_test.cc
  • lib/include/jxl/gain_map.h

Files Modified:

  • lib/extras/dec/jxl.cc
  • lib/extras/enc/jxl.cc
  • lib/extras/packed_image.h
  • lib/extras/packed_image_convert.cc
  • lib/jxl/codec_in_out.h
  • lib/jxl/decode_test.cc
  • lib/jxl/memory_manager_internal.cc
  • lib/jxl/memory_manager_internal.h
  • lib/jxl/padded_bytes.h
  • lib/jxl/test_utils.cc
  • lib/jxl/test_utils.h
  • lib/jxl_lists.bzl
  • lib/jxl_lists.cmake
  • lib/lib.gni
  • tools/cjxl_main.cc

ad84ee99e3f0c33a7d408315668818265870eba2 by Jon Sneyers <jon@cloudinary.com>

https://github.com/libjxl/libjxl/commit/ad84ee99e3f0c33a7d408315668818265870eba2
Authored: 2024-06-04 08:33:10 +0200
Committed: 2024-06-04 06:33:10 +0000

don't print error when loading something that is not a PNG (#3625)

Files Modified:

  • lib/extras/dec/apng.cc

117342ab6afaa94366a77b785fe6754a3aed09ac by Jon Sneyers <jon@cloudinary.com>

https://github.com/libjxl/libjxl/commit/117342ab6afaa94366a77b785fe6754a3aed09ac
Authored: 2024-06-02 17:21:53 +0200
Committed: 2024-06-02 15:21:53 +0000

improve precision and generation loss at very low distance (#3563)

Files Modified:

  • lib/jxl/enc_frame.cc
  • lib/jxl/enc_heuristics.cc
  • lib/jxl/enc_modular.cc
  • lib/jxl/jxl_test.cc
  • lib/jxl/passes_test.cc

c4941e422908eaea0e625fefeef368ab62f2ca5e by Jon Sneyers <jon@cloudinary.com>

https://github.com/libjxl/libjxl/commit/c4941e422908eaea0e625fefeef368ab62f2ca5e
Authored: 2024-06-02 17:21:08 +0200
Committed: 2024-06-02 15:21:08 +0000

fix issues in pam encode/decode (#3620)

Files Modified:

  • lib/extras/dec/pnm.cc
  • lib/extras/enc/pnm.cc

7d76b50370d725b7a4247ca4cecddf603d6bc93b by Eugene Kliuchnikov <eustas@google.com>

https://github.com/libjxl/libjxl/commit/7d76b50370d725b7a4247ca4cecddf603d6bc93b
Authored: 2024-06-01 21:20:53 +0200
Committed: 2024-06-01 19:20:53 +0000

Typos exterminatus (#3619)

Files Added:

  • tools/scripts/typos.toml

Files Modified:

  • .github/workflows/pull_request.yml
  • .github/workflows/test_new_highway.yml
  • ci.sh
  • doc/fuzzing.md
  • lib/extras/dec/apng.cc
  • lib/extras/dec/gif.cc
  • lib/extras/enc/apng.cc
  • lib/extras/time.cc
  • lib/jpegli/adaptive_quantization.cc
  • lib/jpegli/dct-inl.h
  • lib/jpegli/decode_internal.h
  • lib/jpegli/downsample.cc
  • lib/jpegli/encode.cc
  • lib/jpegli/encode_finish.cc
  • lib/jpegli/encode_streaming.cc
  • lib/jpegli/entropy_coding.cc
  • lib/jpegli/error.cc
  • lib/jpegli/error_handling_test.cc
  • lib/jpegli/idct.cc
  • lib/jpegli/render.cc
  • lib/jpegli/streaming_test.cc
  • lib/jpegli/test_utils-inl.h
  • lib/jpegli/test_utils.cc
  • lib/jxl/butteraugli/butteraugli_test.cc
  • lib/jxl/cms/jxl_cms_internal.h
  • lib/jxl/coeff_order.h
  • lib/jxl/convolve-inl.h
  • lib/jxl/dct-inl.h
  • lib/jxl/decode_test.cc
  • lib/jxl/enc_ac_strategy.cc
  • lib/jxl/enc_adaptive_quantization.cc
  • lib/jxl/enc_fast_lossless.cc
  • lib/jxl/enc_group.cc
  • lib/jxl/image_metadata.cc
  • lib/jxl/modular/encoding/enc_ma.cc
  • lib/jxl/modular/transform/squeeze.cc
  • lib/jxl/render_pipeline/simple_render_pipeline.cc
  • lib/jxl/render_pipeline/test_render_pipeline_stages.h
  • lib/jxl/roundtrip_test.cc
  • lib/jxl/test_utils.cc
  • plugins/gimp/file-jxl-load.cc
  • tools/butteraugli_main.cc
  • tools/conformance/lcms2.py
  • tools/optimizer/apply_simplex.py
  • tools/wasm_demo/manual_decode_demo.html

c84ea27331eca6b05bf2888a26d8e321edb06473 by Eugene Kliuchnikov <eustas@google.com>

https://github.com/libjxl/libjxl/commit/c84ea27331eca6b05bf2888a26d8e321edb06473
Authored: 2024-05-30 21:43:12 +0200
Committed: 2024-05-30 19:43:12 +0000

Fix includes (#3618)

Files Modified:

  • lib/extras/dec/pgx_test.cc
  • lib/jxl/bit_reader_test.cc
  • lib/jxl/butteraugli/butteraugli_test.cc
  • lib/jxl/chroma_from_luma.cc
  • lib/jxl/chroma_from_luma.h
  • lib/jxl/codec_in_out.h
  • lib/jxl/coeff_order_test.cc
  • lib/jxl/dec_context_map.cc
  • lib/jxl/dec_context_map.h
  • lib/jxl/dec_group.h
  • lib/jxl/dec_patch_dictionary.h
  • lib/jxl/decode_test.cc
  • lib/jxl/enc_bit_writer.h
  • lib/jxl/entropy_coder.h
  • lib/jxl/gradient_test.cc
  • lib/jxl/icc_codec_test.cc
  • lib/jxl/image_bundle_test.cc
  • lib/jxl/jpeg/enc_jpeg_data.h
  • lib/jxl/modular_test.cc
  • lib/jxl/padded_bytes_test.cc
  • lib/jxl/passes_state.h
  • lib/jxl/passes_test.cc
  • lib/jxl/patch_dictionary_internal.h
  • lib/jxl/render_pipeline/stage_patches.h
  • lib/jxl/splines_test.cc
  • lib/jxl/toc_test.cc
  • tools/benchmark/benchmark_args.cc
  • tools/benchmark/benchmark_codec_custom.cc
  • tools/cjxl_fuzzer.cc
  • tools/ssimulacra2.cc

c8e435cbe70fac9679d05367e8297c0a27aacd13 by Eugene Kliuchnikov <eustas@google.com>

https://github.com/libjxl/libjxl/commit/c8e435cbe70fac9679d05367e8297c0a27aacd13
Authored: 2024-05-30 16:22:07 +0200
Committed: 2024-05-30 14:22:07 +0000

Isolate move FUZZ_TEST and MemoryManager() out of test_utils (#3617)

Files Added:

  • lib/jpegli/fuzztest.h
  • lib/jxl/fuzztest.h
  • lib/jxl/test_memory_manager.cc
  • lib/jxl/test_memory_manager.h

Files Modified:

  • lib/extras/dec/pgx_test.cc
  • lib/jpegli/test_utils.h
  • lib/jxl/ans_test.cc
  • lib/jxl/bit_reader_test.cc
  • lib/jxl/butteraugli/butteraugli_test.cc
  • lib/jxl/coeff_order_test.cc
  • lib/jxl/color_management_test.cc
  • lib/jxl/convolve_test.cc
  • lib/jxl/decode_test.cc
  • lib/jxl/enc_external_image_test.cc
  • lib/jxl/enc_gaborish_test.cc
  • lib/jxl/encode_test.cc
  • lib/jxl/fast_math_test.cc
  • lib/jxl/fields_test.cc
  • lib/jxl/gradient_test.cc
  • lib/jxl/icc_codec_test.cc
  • lib/jxl/image_bundle_test.cc
  • lib/jxl/image_ops_test.cc
  • lib/jxl/jxl_test.cc
  • lib/jxl/modular_test.cc
  • lib/jxl/opsin_image_test.cc
  • lib/jxl/opsin_inverse_test.cc
  • lib/jxl/padded_bytes_test.cc
  • lib/jxl/passes_test.cc
  • lib/jxl/patch_dictionary_test.cc
  • lib/jxl/preview_test.cc
  • lib/jxl/quant_weights_test.cc
  • lib/jxl/quantizer_test.cc
  • lib/jxl/render_pipeline/render_pipeline_test.cc
  • lib/jxl/roundtrip_test.cc
  • lib/jxl/splines_test.cc
  • lib/jxl/test_utils.cc
  • lib/jxl/test_utils.h
  • lib/jxl/toc_test.cc
  • lib/jxl_lists.bzl
  • lib/jxl_lists.cmake
  • lib/lib.gni
  • tools/cjxl_fuzzer.cc
  • tools/color_encoding_fuzzer.cc
  • tools/decode_basic_info_fuzzer.cc
  • tools/djxl_fuzzer.cc
  • tools/fields_fuzzer.cc
  • tools/gauss_blur_test.cc
  • tools/icc_codec_fuzzer.cc
  • tools/jpegli_dec_fuzzer.cc
  • tools/rans_fuzzer.cc
  • tools/set_from_bytes_fuzzer.cc
  • tools/streaming_fuzzer.cc
  • tools/transforms_fuzzer.cc

784e43eb5807d75ee8ca1eb53540a75f6b729301 by Jon Sneyers <jon@cloudinary.com>

https://github.com/libjxl/libjxl/commit/784e43eb5807d75ee8ca1eb53540a75f6b729301
Authored: 2024-05-30 15:36:36 +0200
Committed: 2024-05-30 13:36:36 +0000

more benchmark_xl output (#3589)

Files Modified:

  • tools/benchmark/benchmark_stats.cc
  • tools/benchmark/benchmark_stats.h
  • tools/benchmark/benchmark_xl.cc

a8a0c3d9fca33357e3615116b35c411446d088cc by Eugene Kliuchnikov <eustas@google.com>

https://github.com/libjxl/libjxl/commit/a8a0c3d9fca33357e3615116b35c411446d088cc
Authored: 2024-05-30 15:02:48 +0200
Committed: 2024-05-30 13:02:48 +0000

Fix clang-tidy findings (#3615)

Drive-by: improve clang-tidy bin selection

Files Modified:

  • .clang-tidy
  • ci.sh
  • lib/extras/dec/apng.cc
  • lib/extras/dec/exr.cc
  • lib/extras/dec/jxl.cc
  • lib/extras/enc/jpg.cc
  • lib/extras/packed_image_convert.cc
  • lib/extras/tone_mapping_gbench.cc
  • lib/jpegli/dct-inl.h
  • lib/jpegli/idct.cc
  • lib/jpegli/test_utils.h
  • lib/jxl/ac_strategy.cc
  • lib/jxl/base/compiler_specific.h
  • lib/jxl/base/scope_guard.h
  • lib/jxl/cms/jxl_cms_internal.h
  • lib/jxl/cms/tone_mapping_test.cc
  • lib/jxl/dct_scales.cc
  • lib/jxl/dec_external_image_gbench.cc
  • lib/jxl/dec_group_border.cc
  • lib/jxl/dec_group_border.h
  • lib/jxl/decode.cc
  • lib/jxl/enc_adaptive_quantization.cc
  • lib/jxl/enc_cache.cc
  • lib/jxl/enc_external_image_gbench.cc
  • lib/jxl/enc_fast_lossless.cc
  • lib/jxl/enc_fast_lossless.h
  • lib/jxl/enc_patch_dictionary.cc
  • lib/jxl/encode.cc
  • lib/jxl/entropy_coder.cc
  • lib/jxl/image.h
  • lib/jxl/jpeg/dec_jpeg_output_chunk.h
  • lib/jxl/jpeg/enc_jpeg_data.cc
  • lib/jxl/memory_manager_internal.h
  • lib/jxl/modular/encoding/enc_ma.cc
  • lib/jxl/quant_weights.cc
  • lib/jxl/quantizer.cc
  • lib/jxl/render_pipeline/stage_tone_mapping.cc
  • lib/jxl/render_pipeline/stage_write.cc
  • lib/jxl/splines_gbench.cc
  • lib/jxl/test_utils.h
  • tools/benchmark/benchmark_codec.cc
  • tools/benchmark/benchmark_utils.cc
  • tools/benchmark/benchmark_xl.cc
  • tools/cjxl_main.cc
  • tools/icc_simplify.cc
  • tools/thread_pool_internal.h

4c99aeb91325c2c333ee9a4d46ef3081ae48a2aa by Eugene Kliuchnikov <eustas@google.com>

https://github.com/libjxl/libjxl/commit/4c99aeb91325c2c333ee9a4d46ef3081ae48a2aa
Authored: 2024-05-30 15:02:22 +0200
Committed: 2024-05-30 13:02:22 +0000

Speedup MSAN/TSAN tests; UB is checked on ASAN build. (#3614)

Files Modified:

  • ci.sh

a00f5af111a739aff8222a00bca496afa3aa23e7 by Eugene Kliuchnikov <eustas@google.com>

https://github.com/libjxl/libjxl/commit/a00f5af111a739aff8222a00bca496afa3aa23e7
Authored: 2024-05-29 11:01:17 +0200
Committed: 2024-05-29 09:01:17 +0000

Speedup debug tests (#3613)

Files Modified:

  • CMakeLists.txt
  • ci.sh

cb45f3b2f7f26d7c13e79802bf8136f4d89cbf10 by Eugene Kliuchnikov <eustas@google.com>

https://github.com/libjxl/libjxl/commit/cb45f3b2f7f26d7c13e79802bf8136f4d89cbf10
Authored: 2024-05-29 10:46:10 +0200
Committed: 2024-05-29 08:46:10 +0000

Somewhat fix MSAN build (#3603)

Files Modified:

  • .github/workflows/build_test.yml
  • ci.sh

d58d525bc9faaa18f422dbded9226292e15c33cd by Eugene Kliuchnikov <eustas@google.com>

https://github.com/libjxl/libjxl/commit/d58d525bc9faaa18f422dbded9226292e15c33cd
Authored: 2024-05-28 18:07:43 +0200
Committed: 2024-05-28 16:07:43 +0000

More jpeglib unpoisoning (#3610)

Files Modified:

  • lib/jpegli/libjpeg_test_util.cc

702456c017be33349750a0b183457ee4b6c8641e by Sami Boukortt <sboukortt@google.com>

https://github.com/libjxl/libjxl/commit/702456c017be33349750a0b183457ee4b6c8641e
Authored: 2024-05-28 16:24:45 +0200
Committed: 2024-05-28 14:24:45 +0000

Remove usage of obsolete macro c_plusplus (#3612)

Files Modified:

  • lib/include/jxl/cms_interface.h
  • lib/include/jxl/codestream_header.h
  • lib/include/jxl/color_encoding.h
  • lib/include/jxl/decode.h
  • lib/include/jxl/decode_cxx.h
  • lib/include/jxl/encode.h
  • lib/include/jxl/encode_cxx.h
  • lib/include/jxl/memory_manager.h
  • lib/include/jxl/parallel_runner.h
  • lib/include/jxl/resizable_parallel_runner.h
  • lib/include/jxl/resizable_parallel_runner_cxx.h
  • lib/include/jxl/stats.h
  • lib/include/jxl/thread_parallel_runner.h
  • lib/include/jxl/thread_parallel_runner_cxx.h
  • lib/include/jxl/types.h
  • lib/jpegli/common.h
  • lib/jpegli/decode.h
  • lib/jpegli/encode.h
  • lib/jpegli/types.h

d3e613f2306bb76975e1fb7dbbaa98af59440496 by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/libjxl/libjxl/commit/d3e613f2306bb76975e1fb7dbbaa98af59440496
Authored: 2024-05-27 16:49:48 +0200
Committed: 2024-05-27 14:49:48 +0000

Bump github/codeql-action from 3.25.5 to 3.25.6 (#3607)

Bumps github/codeql-action from 3.25.5 to 3.25.6.

updated-dependencies:

  • dependency-name: github/codeql-action
    dependency-type: direct:production
    update-type: version-update:semver-patch
    ...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Files Modified:

  • .github/workflows/codeql.yml
  • .github/workflows/scorecard.yml

d49cb87f6439dfd58f31767e2235ee2807fbdc70 by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/libjxl/libjxl/commit/d49cb87f6439dfd58f31767e2235ee2807fbdc70
Authored: 2024-05-27 16:49:31 +0200
Committed: 2024-05-27 14:49:31 +0000

Bump step-security/harden-runner from 2.7.1 to 2.8.0 (#3608)

Bumps step-security/harden-runner from 2.7.1 to 2.8.0.

updated-dependencies:

  • dependency-name: step-security/harden-runner
    dependency-type: direct:production
    update-type: version-update:semver-minor
    ...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Files Modified:

  • .github/workflows/build_test.yml
  • .github/workflows/build_test_bazel.yml
  • .github/workflows/build_test_cross.yml
  • .github/workflows/build_test_md.yml
  • .github/workflows/build_test_msys2.yml
  • .github/workflows/build_test_wasm.yml
  • .github/workflows/codeql.yml
  • .github/workflows/conformance.yml
  • .github/workflows/debug_ci.yml
  • .github/workflows/dependency-review.yml
  • .github/workflows/fuzz.yml
  • .github/workflows/gitlab_mirror.yml
  • .github/workflows/pull_request.yml
  • .github/workflows/release.yaml
  • .github/workflows/scorecard.yml
  • .github/workflows/test_new_highway.yml

0e45812380f7a3f71e3b2086587b76f977572984 by Eugene Kliuchnikov <eustas@google.com>

https://github.com/libjxl/libjxl/commit/0e45812380f7a3f71e3b2086587b76f977572984
Authored: 2024-05-27 12:18:19 +0200
Committed: 2024-05-27 10:18:19 +0000

Fix UBSAN finding (#3606)

Files Modified:

  • lib/jxl/dec_patch_dictionary.cc

45e688cb6df41203a29e9f9d8fa946f34ba171cd by Eugene Kliuchnikov <eustas@google.com>

https://github.com/libjxl/libjxl/commit/45e688cb6df41203a29e9f9d8fa946f34ba171cd
Authored: 2024-05-24 14:19:28 +0200
Committed: 2024-05-24 12:19:28 +0000

Alternative fix for MSAN finding (#3600)

Files Modified:

  • lib/jxl/dec_cache.cc
  • lib/jxl/dec_frame.cc
  • lib/jxl/dec_noise.cc
  • lib/jxl/dec_noise.h
  • lib/jxl/dec_patch_dictionary.cc
  • lib/jxl/dec_patch_dictionary.h
  • lib/jxl/enc_frame.cc
  • lib/jxl/enc_heuristics.cc
  • lib/jxl/enc_patch_dictionary.cc
  • lib/jxl/enc_patch_dictionary.h
  • lib/jxl/passes_state.cc
  • lib/jxl/passes_state.h
  • lib/jxl/render_pipeline/stage_patches.cc
  • lib/jxl/render_pipeline/stage_patches.h

7974d88de59622a7fba010fb75b22cf03ffc037d by Eugene Kliuchnikov <eustas@google.com>

https://github.com/libjxl/libjxl/commit/7974d88de59622a7fba010fb75b22cf03ffc037d
Authored: 2024-05-24 11:23:42 +0200
Committed: 2024-05-24 09:23:42 +0000

Temporary silence MSAN failure (#3602)

Files Modified:

  • lib/jxl/jxl_test.cc

aac751a9f4ca8259e00de22df4744d9149aeb0ce by Moritz Firsching <firsching@google.com>

https://github.com/libjxl/libjxl/commit/aac751a9f4ca8259e00de22df4744d9149aeb0ce
Authored: 2024-05-23 11:34:27 +0200
Committed: 2024-05-23 09:34:27 +0000

fix perceptual typo (#3601)

Files Modified:

  • lib/jxl/enc_frame.cc
  • lib/jxl/enc_heuristics.cc
  • lib/jxl/enc_params.h
  • lib/jxl/enc_patch_dictionary.cc
  • lib/jxl/encode.cc

4451ce9fdd3780cc0ad5cf1fea529615a6d84f2d by John Platts <john_platts@hotmail.com>

https://github.com/libjxl/libjxl/commit/4451ce9fdd3780cc0ad5cf1fea529615a6d84f2d
Authored: 2024-05-21 04:51:53 -0500
Committed: 2024-05-21 09:51:53 +0000

Updated CMake build to compile in C++17 mode if available (#3590)

Co-authored-by: Eugene Kliuchnikov <eustas@google.com>

Files Modified:

  • AUTHORS
  • CMakeLists.txt
  • lib/jpegli/common_internal.h
  • lib/jxl/enc_coeff_order.cc
  • lib/jxl/enc_huffman_tree.cc

a332e8ed9c29d6fc6d3e71a70e0be54a47327a26 by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/libjxl/libjxl/commit/a332e8ed9c29d6fc6d3e71a70e0be54a47327a26
Authored: 2024-05-20 18:48:00 +0000
Committed: 2024-05-20 18:48:00 +0000

Bump codecov/codecov-action from 4.3.1 to 4.4.1 (#3596)

Bumps codecov/codecov-action from 4.3.1 to 4.4.1.

updated-dependencies:

  • dependency-name: codecov/codecov-action
    dependency-type: direct:production
    update-type: version-update:semver-minor
    ...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Files Modified:

  • .github/workflows/build_test.yml

408821d2dbd50fc7e0c24a182cac75a859d2e776 by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/libjxl/libjxl/commit/408821d2dbd50fc7e0c24a182cac75a859d2e776
Authored: 2024-05-20 20:22:29 +0200
Committed: 2024-05-20 18:22:29 +0000

Bump actions/checkout from 4.1.5 to 4.1.6 (#3595)

Bumps actions/checkout from 4.1.5 to 4.1.6.

updated-dependencies:

  • dependency-name: actions/checkout
    dependency-type: direct:production
    update-type: version-update:semver-patch
    ...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Files Modified:

  • .github/workflows/build_test.yml
  • .github/workflows/build_test_bazel.yml
  • .github/workflows/build_test_cross.yml
  • .github/workflows/build_test_msys2.yml
  • .github/workflows/build_test_wasm.yml
  • .github/workflows/codeql.yml
  • .github/workflows/conformance.yml
  • .github/workflows/debug_ci.yml
  • .github/workflows/dependency-review.yml
  • .github/workflows/fuzz.yml
  • .github/workflows/gitlab_mirror.yml
  • .github/workflows/pages.yml
  • .github/workflows/pull_request.yml
  • .github/workflows/release.yaml
  • .github/workflows/scorecard.yml
  • .github/workflows/test_new_highway.yml

8835f5dfc4857f46277f6c703e47ac7817bd7aed by Eugene Kliuchnikov <eustas@google.com>

https://github.com/libjxl/libjxl/commit/8835f5dfc4857f46277f6c703e47ac7817bd7aed
Authored: 2024-05-17 09:28:52 +0200
Committed: 2024-05-17 07:28:52 +0000

Actually use JxlMemoryManager (#3582)

Files Deleted:

  • lib/jxl/cache_aligned.cc
  • lib/jxl/cache_aligned.h

Files Modified:

  • lib/extras/dec/jxl.cc
  • lib/extras/dec/jxl.h
  • lib/extras/enc/jxl.cc
  • lib/extras/enc/jxl.h
  • lib/jxl/chroma_from_luma.cc
  • lib/jxl/chroma_from_luma.h
  • lib/jxl/dec_ans.cc
  • lib/jxl/dec_ans.h
  • lib/jxl/dec_cache.cc
  • lib/jxl/dec_frame.cc
  • lib/jxl/dec_group.cc
  • lib/jxl/dec_modular.cc
  • lib/jxl/enc_ac_strategy.cc
  • lib/jxl/enc_chroma_from_luma.cc
  • lib/jxl/enc_chroma_from_luma.h
  • lib/jxl/enc_dot_dictionary.cc
  • lib/jxl/enc_dot_dictionary.h
  • lib/jxl/enc_frame.cc
  • lib/jxl/enc_group.cc
  • lib/jxl/enc_heuristics.cc
  • lib/jxl/enc_modular.cc
  • lib/jxl/enc_patch_dictionary.cc
  • lib/jxl/encode.cc
  • lib/jxl/encode_internal.h
  • lib/jxl/fields_test.cc
  • lib/jxl/image.cc
  • lib/jxl/image.h
  • lib/jxl/image_ops_test.cc
  • lib/jxl/memory_manager_internal.cc
  • lib/jxl/memory_manager_internal.h
  • lib/jxl/padded_bytes.h
  • lib/jxl/render_pipeline/render_pipeline_test.cc
  • lib/jxl/render_pipeline/stage_noise.cc
  • lib/jxl/render_pipeline/stage_noise.h
  • lib/jxl/render_pipeline/stage_write.cc
  • lib/jxl/simd_util.cc
  • lib/jxl/simd_util.h
  • lib/jxl/splines.cc
  • lib/jxl/splines.h
  • lib/jxl/splines_gbench.cc
  • lib/jxl/splines_test.cc
  • lib/jxl_lists.bzl
  • lib/jxl_lists.cmake
  • lib/lib.gni
  • tools/benchmark/benchmark_codec.cc
  • tools/benchmark/benchmark_codec.h
  • tools/benchmark/benchmark_codec_jxl.cc
  • tools/benchmark/benchmark_codec_jxl.h
  • tools/benchmark/benchmark_xl.cc
  • tools/jxl_from_tree.cc

81f1f53f25ec044330ce7b2a410edbc2f8575e68 by Jyrki Alakuijala <jyrki@google.com>

https://github.com/libjxl/libjxl/commit/81f1f53f25ec044330ce7b2a410edbc2f8575e68
Authored: 2024-05-15 19:07:49 +0200
Committed: 2024-05-15 17:07:49 +0000

Gaborish adjustment, more precise for high quality (#3586)

Encoding      kPixels    Bytes          BPP  E MP/s  D MP/s     Max norm  SSIMULACRA2   PSNR        pnorm       BPP*pnorm   QABPP   Bugs
----------------------------------------------------------------------------------------------------------------------------------------
jxl:d0.1        20315 17771024    6.9979205   1.083  10.777   0.35756577  95.39413774  55.88   0.11792287  0.825214859523   6.998      0
jxl:d0.5        20315  7252143    2.8557679   1.284  15.072   0.78009917  91.43862540  47.13   0.33393541  0.953642033483   2.944      0
jxl:d0.8        20315  5367111    2.1134751   1.174  15.958   1.11498186  88.72067125  44.51   0.47189587  0.997340150865   2.494      0
jxl:d1          20315  4606615    1.8140049   1.198  16.140   1.33978720  86.93643661  43.28   0.56051359  1.016774427528   2.535      0
jxl:d1.5        20315  3495106    1.3763120   1.171  15.575   1.86243967  82.75276197  41.14   0.76111748  1.047535130323   2.673      0
jxl:d2.0        20315  2841131    1.1187880   1.219  16.153   2.39270883  78.72248340  39.64   0.95068901  1.063619476080   2.823      0
jxl:d2.5        20315  2391176    0.9416036   1.230  16.769   2.85363662  74.90745005  38.44   1.12566896  1.059933899631   2.821      0
jxl:d3          20315  2084298    0.8207603   1.169  16.651   3.27099277  71.57564628  37.60   1.28291115  1.052962585207   2.801      0
jxl:d5          20315  1396215    0.5498052   1.175  11.051   4.60528606  60.08180640  35.30   1.81269081  0.996626849726   2.631      0
jxl:d10         20315   841857    0.3315087   1.176  12.008   7.65826483  38.55099789  32.51   2.92552904  0.969838209567   2.531      0
Aggregate:      20315  3363578    1.3245185   1.187  14.425   1.89943602  74.74511614  41.09   0.75185110  0.995840722234   2.960      0

Encoding      kPixels    Bytes          BPP  E MP/s  D MP/s     Max norm  SSIMULACRA2   PSNR        pnorm       BPP*pnorm   QABPP   Bugs
----------------------------------------------------------------------------------------------------------------------------------------
jxl:d0.1        20315 17766371    6.9960882   1.093  10.338   0.32866526  95.56544829  56.41   0.10370099  0.725501299870   7.014      0
jxl:d0.5        20315  7257022    2.8576892   1.284  15.103   0.77189099  91.50635825  47.20   0.32944160  0.941441693676   2.940      0
jxl:d0.8        20315  5369016    2.1142252   1.180  15.430   1.11768504  88.79989471  44.53   0.46965892  0.992964741019   2.493      0
jxl:d1          20315  4609246    1.8150410   1.196  15.738   1.33782778  86.98780844  43.30   0.55832773  1.013387710805   2.536      0
jxl:d1.5        20315  3497199    1.3771362   1.207  15.962   1.85855401  82.81295438  41.16   0.76009258  1.046751002825   2.656      0
jxl:d2.0        20315  2843156    1.1195854   1.220  16.059   2.41777601  78.77166762  39.63   0.94948695  1.063031760887   2.848      0
jxl:d2.5        20315  2394127    0.9427656   1.228  16.526   2.84988972  74.99224027  38.44   1.12556297  1.061142061097   2.819      0
jxl:d3          20315  2083912    0.8206083   1.184  16.452   3.26822970  71.60239559  37.59   1.28327248  1.053064099262   2.811      0
jxl:d5          20315  1395134    0.5493795   1.180  11.168   4.60916078  60.13079585  35.29   1.81183388  0.995384445464   2.621      0
jxl:d10         20315   842026    0.3315752   1.174  11.917   7.64110776  38.58375043  32.51   2.92833970  0.970964848671   2.514      0
Aggregate:      20315  3364628    1.3249321   1.194  14.276   1.88258220  74.80896744  41.14   0.74046019  0.981059483733   2.959      0

Files Modified:

  • lib/jxl/enc_gaborish.cc
  • lib/jxl/enc_heuristics.cc
  • lib/jxl/passes_test.cc
  • lib/jxl/roundtrip_test.cc

64b12f0cfcfd5942ad1872329a5e06ec5a9669d4 by Sami Boukortt <sboukortt@google.com>

https://github.com/libjxl/libjxl/commit/64b12f0cfcfd5942ad1872329a5e06ec5a9669d4
Authored: 2024-05-15 15:22:52 +0200
Committed: 2024-05-15 13:22:52 +0000

TF_SRGB: use HWY_REP4 (#3587)

Files Modified:

  • lib/jxl/cms/transfer_functions-inl.h

./mach vendor media/libjxl/moz.yaml reported an error editing moz.build files:

Latest commit is ba1bfac861315803dc53888abddca8f665c8edf3 from 2024-06-04T13:15:38Z
Fetching code archive from https://github.com/libjxl/libjxl/archive/ba1bfac861315803dc53888abddca8f665c8edf3.tar.gz
Retaining wanted in-tree files.
Cleaning third_party/jpeg-xl to import changes.
Unpacking upstream files for third_party/jpeg-xl.
Retaining wanted files from upstream changes.
Removing excluded files from upstream changes.
Removing: [/tmp/tmphzfu9npm/.github/ISSUE_TEMPLATE/bug_report.md, /tmp/tmphzfu9npm/.github/ISSUE_TEMPLATE/feature_request.md, /tmp/tmphzfu9npm/.github/PULL_REQUEST_TEMPLATE.md, /tmp/tmphzfu9npm/.github/dependabot.yml, 18 (omitted) items in /tmp/tmphzfu9npm/.github/workflows, /tmp/tmphzfu9npm/.gitignore, /tmp/tmphzfu9npm/.gitmodules, 19 (omitted) items in /tmp/tmphzfu9npm/doc, /tmp/tmphzfu9npm/doc/man/cjxl.txt, /tmp/tmphzfu9npm/doc/man/djxl.txt, 11 (omitted) items in /tmp/tmphzfu9npm/doc/sphinx, /tmp/tmphzfu9npm/lib/lib.gni, 55 (omitted) items in /tmp/tmphzfu9npm/tools, 23 (omitted) items in /tmp/tmphzfu9npm/tools/benchmark, 3 items in /tmp/tmphzfu9npm/tools/benchmark/hm: README.md, decode.sh and encode.sh, 18 (omitted) items in /tmp/tmphzfu9npm/tools/benchmark/metrics, 16 (omitted) items in /tmp/tmphzfu9npm/tools/comparison_viewer, 5 items in /tmp/tmphzfu9npm/tools/conformance: CMakeLists.txt, conformance.py, generator.py, lcms2.py and tooling_test.sh, 7 items in /tmp/tmphzfu9npm/tools/fast_lossless: .gitignore, README.md, build-android.sh, build.sh, cross_compile_aarch64.sh, fast_lossless_main.cc and pam-input.h, 12 (omitted) items in /tmp/tmphzfu9npm/tools/flicker_test, 10 (omitted) items in /tmp/tmphzfu9npm/tools/hdr, 4 items in /tmp/tmphzfu9npm/tools/icc_detect: icc_detect.h, icc_detect_empty.cc, icc_detect_win32.cc and icc_detect_x11.cc, 10 (omitted) items in /tmp/tmphzfu9npm/tools/jni/org/jpeg/jpegxl/wrapper, 3 items in /tmp/tmphzfu9npm/tools/optimizer: apply_simplex.py, simplex_fork.py and update_jpegli_global_scale.py, 21 (omitted) items in /tmp/tmphzfu9npm/tools/scripts, /tmp/tmphzfu9npm/tools/upscaling_coefficients/generate_upscaling_coefficients.py, /tmp/tmphzfu9npm/tools/upscaling_coefficients/upscaler_demo.py, 7 items in /tmp/tmphzfu9npm/tools/viewer: CMakeLists.txt, load_jxl.cc, load_jxl.h, main.cc, viewer_window.cc, viewer_window.h and viewer_window.ui, 16 (omitted) items in /tmp/tmphzfu9npm/tools/wasm_demo, /tmp/tmphzfu9npm/tools/wasm_demo/netlify/edge-functions/precompressed.ts]
Copying to third_party/jpeg-xl.
Checking for update actions
Registering changes with version control.
Checking for a spurious update.
Version 'ba1bfac861315803dc53888abddca8f665c8edf3' has changed 185 files.
Updating moz.yaml.
Found release: 715b44238e67e521bba944e2864eb2933296e51c (2024-05-14T15:25:56Z).

Found revision: 715b44238e67e521bba944e2864eb2933296e51c

Updating moz.build files
Found 3 files added and 2 files removed.
Could not add third_party/jpeg-xl/lib/extras/gain_map.cc to the appropriate moz.build file
Could not add third_party/jpeg-xl/lib/extras/gain_map_test.cc to the appropriate moz.build file
Could not remove third_party/jpeg-xl/lib/jxl/cache_aligned.h from the appropriate moz.build file
This is a deficiency in ./mach vendor . Please review the affected files before committing.

We're going to continue processing the update; but we may fail because we couldn't handle these files. If we do succeed, you may want to add these files to the 'exclude' key in the moz.yaml file, so they are excluded from the source tree and ignored in the future.

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=ce073db521d20d07936d85773586c8b5612ab23f

Severity: -- → S3

The try push is done, we found jobs with unclassified failures.

Needs Close Investigation:

  • test-android-em-7.0-x86_64-qr/debug-isolated-process-geckoview-junit-nofis - 3 of 4 failed on the same (retriggered) task (failed: afrfFx-ITzqjuLvshEr4AA, MiucD_35QxaG4Wf9BEyHcQ, EvCdqKKmQD-J5Zp0DHsCUQ)

Needs Investigation (Possible Intermittents):

  • test-android-em-7.0-x86_64-qr/opt-geckoview-junit-nofis - 1 of 4 failed on the same (retriggered) task (failed: ah3YwnxLQS-Cz5uQ3DLBJg)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor media/libjxl/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Assignee: nobody → krosylight
Flags: needinfo?(krosylight)
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/151cb0c06eea Update libjxl to ba1bfac861315803dc53888abddca8f665c8edf3 r=saschanaz
Flags: needinfo?(krosylight)

https://hg.mozilla.org/mozilla-central/rev/151cb0c06eea

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox128: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: