1900684 - CodeMirror6: Selecting text and changing the source leads to a blank editor

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Julian Descottes [:jdescottes]]

STRs:

• enable code mirror 6 (devtools.debugger.features.codemirror-next = true)
• open devtools > debugger
• open 2 sources
• on the selected source, select some text
• switch to the other source

ER: Source should be displayed
AR: Editor is blank

Clicking anywhere in the editor fixes the issue.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: cm6_blank_editor.mp4

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900684 - [devtools] Reset the selection when changing editor content r=#devtools-reviewers

The issue here is a selection becomes stale once the editor content changes, and codemirror
no longer knows how to render the old selection with the new content (causing blank editor).
Once the user clicks, this resets the selection which causes the editor content to display properly.

To fix this we reset the selection as we reset the editor content.
Unfortunately we lose the previous selection (even if we go back).

Depends on D213872

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8611db0b6023
[devtools] Reset the selection when changing editor content r=devtools-reviewers,nchevobbe

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8611db0b6023