1900741 - CodeMirror6: Clicking on the right of the line number does not toggle breakpoints

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Julian Descottes [:jdescottes]]

Attachment: image.png

With the new editor, I can only set breakpoints when clicking on the line number or to the left of the line number. All the blank space between the line number and the gutter can't be used to set or remove breakpoints.

I understand that this part of the UI usually contains toggles to collapse blocks/functions, but it makes me feel like the UI is not responding, so we should either fix it or find a way to indicate to the user that this cannot be clicked.

Comment 1

[Hubert Boma Manilla (:bomsy)]

So the issue here is a difference in CM5 and CM6. In CM5 the events where attached to the whole gutter (line numbers and code folding) as this was one component. In CM6 the line numbers and code folding are different extensions which make it a bit difficult to handle together.

I'll see if i can attach the same DOM event handlers passed to the line numbers extension to the code folding extension to see if that works seamlessly, if not, we try to make it clear to the user that it won't work (Maybe switching the order and putting the line numbers on the right side might help).

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900741 - [devtools] Enable events for all the gutter r=#devtools-reviewers

This patch

• Adds the gutter hover styling to help indicate which lines can be clicked.
• Fix triggering events on the whole gutter panel (including the code folder).

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: hover_on_gutter.mp4

Attaching the small hover issue I spotted during the last review: when moving the mouse on the gutter area, the hover style is not displayed, so we don't know if clicking will add a breakpoint or not (and since we can't tell breakable and non-breakable lines in dark mode, it can be confusing)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67ffb942765a
[devtools] Enable events for all the gutter r=devtools-reviewers,jdescottes,nchevobbe

Comment 5

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/67ffb942765a