1900846 - Emit gecko profiler markers as perfetto track events

Status: RESOLVED FIXED

(Core :: Performance Engineering, enhancement)

Description

[Denis Palmeiro [:denispal]]

We have perfetto integration within Firefox for Android, but we only currently emit two track events for user timing markers and taskcontroller tasks. We should instead emit all existing gecko profiler markers as perfetto track events as well.

Comment 1

[Denis Palmeiro [:denispal]]

Attachment: Bug 1900846: Emit gecko profiler markers as perfetto track events if enabled. r=canaltinova!

Comment 2

[Denis Palmeiro [:denispal]]

Attachment: WIP: Bug 1900846: WIP Emit GC marker payload to perfetto

Depends on D214033

Comment 3

[Denis Palmeiro [:denispal]]

Attachment: Bug 1900846: Add perfetto track event specialization for the NetworkMarker. r=canaltinova!

Depends on D216733

Comment 4

[Denis Palmeiro [:denispal]]

Attachment: Bug 1900846: Pass each individual field as parameters instead of the CycleCollectorResults struct when emitting the CCIntervalMarker profiler marker. r=canaltinova!

The CCIntervalMarker marker accepts a CycleCollectorResults struct as one of it's parameters and emits each field individually during StreamJSONMarkerData. This is difficult to translate to a perfetto track event, so instead pass each field directly to profiler_add_marker so that the parameters line up with the PayloadFields descriptions.

Depends on D216734

Comment 5

[Denis Palmeiro [:denispal]]

Attachment: Bug 1900846: Remove duplicate definitions of perfetto macros. r=canaltinova!

This patch removes some duplicate macro definitions for the perfetto macro's, such as TRACE_EVENT_BEGIN. They are not currently used and are mapped to no-op's in this file.

Depends on D217411

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5ba32edc63c
Emit gecko profiler markers as perfetto track events if enabled. r=profiler-reviewers,canaltinova
https://hg.mozilla.org/integration/autoland/rev/5c6c1e590b8c
Add perfetto track event specialization for the NetworkMarker. r=necko-reviewers,canaltinova,jesup
https://hg.mozilla.org/integration/autoland/rev/3a9a742747b0
Pass each individual field as parameters instead of the CycleCollectorResults struct when emitting the CCIntervalMarker profiler marker. r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/3020439d8d51
Remove duplicate definitions of perfetto macros. r=canaltinova,profiler-reviewers

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb02892b5321
Backed out 4 changesets for causing crashes related to MarkerPhase.

Comment 8

[Cosmin Sabou [:CosminS]]

Backed out for causing crashes related to MarkerPhase.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=3020439d8d514f7b474e01a62601311f89520aa8&selectedTaskRun=ce-QRqQwRbq9AkoWVg5BtA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=467796678&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/bb02892b5321da485e119f33862c563a2589cbfc

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c46e5ef4f69
Emit gecko profiler markers as perfetto track events if enabled. r=profiler-reviewers,canaltinova
https://hg.mozilla.org/integration/autoland/rev/5a87c9e315c9
Add perfetto track event specialization for the NetworkMarker. r=necko-reviewers,canaltinova,jesup
https://hg.mozilla.org/integration/autoland/rev/a6a44279e929
Pass each individual field as parameters instead of the CycleCollectorResults struct when emitting the CCIntervalMarker profiler marker. r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/8cd38ce20a6e
Remove duplicate definitions of perfetto macros. r=canaltinova,profiler-reviewers

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7c46e5ef4f69
https://hg.mozilla.org/mozilla-central/rev/5a87c9e315c9
https://hg.mozilla.org/mozilla-central/rev/a6a44279e929
https://hg.mozilla.org/mozilla-central/rev/8cd38ce20a6e