190085 - about:plugins is not working.

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Frederic Bezies]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030122
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030122

I see this on a current CVS trunk build.

When I choose about:plugins in help menu, I have a blank page.

And these error messages in JS console :

Error: [Exception... "Component returned failure code: 0x80004005
(NS_ERROR_FAILURE) [nsIURI.hostPort]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"
 location: "JS frame :: chrome://navigator/content/nsBrowserStatusHandler.js ::
anonymous :: line 350"  data: no]
Source File: chrome://navigator/content/nsBrowserStatusHandler.js
Line: 350

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
jar:resource:///chrome/comm.jar!/content/communicator/plugins.html ::
<TOP_LEVEL> :: line 34"  data: no]

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
jar:resource:///chrome/comm.jar!/content/communicator/plugins.html ::
<TOP_LEVEL> :: line 55"  data: no]






Reproducible: Always

Steps to Reproduce:
1.Just follow details.

Actual Results:  
blank page

Expected Results:  
listing plugins.

Comment 1

[Robert Kaiser]

If this is new, it could easily be my patch :(

Taking and investigating.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Frederic, are you using the English localization?  Or a different one?

Comment 3

[Benedikt Kantus]

I do NOT see this with build 2003012105 (precompiled) on Win 2k. This must be
new for today's build.

Comment 4

[Frederic Bezies]

Only english speaking version of mozilla. I build the lizard from its sources
everyday.

Comment 5

[Robert Kaiser]

Frederick:
What do you get if you type "chrome://communicator/locale/plugins.properties"
into your URL bar? Is that file found in your build?

Benedikt:
Well, in today's builds there are a few changes in about:plugins (It can be
translated/localized now - see bug 56863)

Comment 6

[Frederic Bezies]

Robert (please, no "k" in my name ;-)

Here is the result of your question :

"# LOCALIZATION NOTE (plugins.properties):
#    Those strings are inserted into an HTML page, so you all HTML characters
#    have to be escaped in a way that they show up correctly in HTML!

title_label = About Plug-ins
installedplugins_label = Installed plug-ins
nopluginsareinstalled_label = No plug-ins are installed
findmore_label = Find more information about browser plug-ins at
installhelp_label = Help for installing plug-ins is available from
filename_label = File name:
mimetype_label = MIME Type
description_label  = Description
suffixes_label  = Suffixes
enabled_label = Enabled
yes_label = Yes
no_label = No"

Comment 7

[Robert Kaiser]

Attachment: fix, remove those spaces

I could reproduce it and I could fix it in my local build.

This is the patch, I wrote "key = value" instead of "key=value" in the
properties files (too many spaces). Sorry, such thing shouldn't happen :(

Comment 8

[Robert Kaiser]

Comment on attachment 112321 [details] [diff] [review]
fix, remove those spaces

easy and low-risk fix, just removing superflous spaces around the '=' in those
properties files. sorry for checking in those wrong files previously...

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 112321 [details] [diff] [review]
fix, remove those spaces

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 10

[Boris Zbarsky [:bzbarsky]]

KaiRo, just thought you'd like to know that spaces used to be fine in those
places till alecf's recent checkin.... And will be again once bug 190256 is fixed.

I say still land this patch, but this should make it clear why it worked when
you tested it before checking in... ;)

Comment 11

[Robert Kaiser]

Checking in mozilla/xpfe/communicator/resources/locale/en-US/plugins.properties;
/cvsroot/mozilla/xpfe/communicator/resources/locale/en-US/plugins.properties,v 
<--  plugins.properties
new revision: 1.2; previous revision: 1.1
done
Checking in mozilla/xpfe/communicator/resources/locale/en-US/region.properties;
/cvsroot/mozilla/xpfe/communicator/resources/locale/en-US/region.properties,v 
<--  region.properties
new revision: 1.6; previous revision: 1.5
done

FIXED.

bz:
Thanks for your comment, it's good to know that it's not really my fault :)
Anyway, I found another regression caused by alecf's changes, bug 190283 (you're
CCed already)

Comment 12

[Frederic Bezies]

It is working, but there is - always - an error in JS console :

Error: [Exception... "Component returned failure code: 0x80004005
(NS_ERROR_FAILURE) [nsIURI.hostPort]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"
 location: "JS frame :: chrome://navigator/content/nsBrowserStatusHandler.js ::
anonymous :: line 350"  data: no]
Source File: chrome://navigator/content/nsBrowserStatusHandler.js
Line: 350

Should I have to open a new bug for this ?