1900867 - Tab Hover Preview: Hide the card when clicking on a tab

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Mehmet]

Nightly 128.0a1 (2024-06-05) (64-Bit)

1.) Hover over a tab, so that the hover card preview appears.
2.) Click on the tab.

Actual: The Hover card preview is still to see.
Expected: The Hover card preview should disappear.

Still showing the Hover card preview when selecting the tab is distracting. Please compare with other browsers like Chrome or Safari. There it disappears when clicking/selecting the tab.

Comment 1

[Giorgia Nichita, Release Desktop QA]

After running Mozregression, I arrived at the following pushlog: Mozilla Pushlog. It appears that Bug 1893676 is the cause of the regression.

Prior to Bug 1893676, clicking on non-selected tabs while the tab preview was displayed would close the tab preview. However, the tab preview did not close when clicking on the selected tab or any new tab.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1893676

:dwalker, since you are the author of the regressor, bug 1893676, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1893676

Comment 4

[Chris Peterson [:cpeterson]]

DJ says this isn't a regression; this behavior existing before tab hover preview was enabled.

For comparison, Chrome dismisses a tab's hover preview when you click on the tab.

Comment 5

[Giorgia Nichita, Release Desktop QA]

The issue in Bug 1900867 is a regression because it reintroduces a previously fixed and verified problem from Bug 1879068 ( see comment 2), where the tab hover preview did not disappear upon clicking a tab. This behavior was corrected before and has reappeared now due to changes in Bug 1893676.

Comment 6

[DJ]

Hiding the preview when a tab is clicked was never the intended behavior; I'll have to take a look at the regression range to see what happened. We can make it work either way.

Comment 7

[Chris Peterson [:cpeterson]]

Misha says clicking the background tab should dismiss both the preview screenshot and title (like Chrome does).

Comment 8

[DJ]

Attachment: Bug 1900867 - dismiss tab preview when tab select occurs. r?#tabbrowser-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b34f215d1f10
dismiss tab preview when tab select occurs. r=tabbrowser-reviewers,dao

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b34f215d1f10

Comment 11

[Mehmet]

dwalker@: Many thanks for fixing my reported issue. It feels right, now :) Just only one thing I noticed: The card is not dismissing, when I click on a foreground tab. But I think this is intended, right? It should only dismiss when clicking on a background tab when bringing it to the foreground, right?

Comment 12

[DJ]

Correct, that is currently the expected behavior :)

Comment 13

[Mehmet]

(In reply to DJ (:dwalker) from comment #12)

Correct, that is currently the expected behavior :)

Thanks for your feedback :)