Open Bug 1900867 Opened 23 days ago Updated 3 days ago

Tab Hover Preview: Hide the card when clicking on a tab

Categories

(Firefox :: Tabbed Browser, defect, P2)

defect

Tracking

()

Tracking Status
firefox-esr115 --- unaffected
firefox126 --- unaffected
firefox127 --- unaffected
firefox128 --- disabled
firefox129 --- affected

People

(Reporter: mehmet.sahin, Unassigned)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression)

Nightly 128.0a1 (2024-06-05) (64-Bit)

1.) Hover over a tab, so that the hover card preview appears.
2.) Click on the tab.

Actual: The Hover card preview is still to see.
Expected: The Hover card preview should disappear.

Still showing the Hover card preview when selecting the tab is distracting. Please compare with other browsers like Chrome or Safari. There it disappears when clicking/selecting the tab.

Blocks: 1848157

After running Mozregression, I arrived at the following pushlog: Mozilla Pushlog. It appears that Bug 1893676 is the cause of the regression.

Prior to Bug 1893676, clicking on non-selected tabs while the tab preview was displayed would close the tab preview. However, the tab preview did not close when clicking on the selected tab or any new tab.

Has STR: --- → yes
Keywords: regression
Regressed by: 1893676
See Also: → 1879068

Set release status flags based on info from the regressing bug 1893676

:dwalker, since you are the author of the regressor, bug 1893676, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(dwalker)

Set release status flags based on info from the regressing bug 1893676

DJ says this isn't a regression; this behavior existing before tab hover preview was enabled.

For comparison, Chrome dismisses a tab's hover preview when you click on the tab.

Severity: -- → S4
Keywords: regression
Priority: -- → P2
No longer regressed by: 1893676

The issue in Bug 1900867 is a regression because it reintroduces a previously fixed and verified problem from Bug 1879068 ( see comment 2), where the tab hover preview did not disappear upon clicking a tab. This behavior was corrected before and has reappeared now due to changes in Bug 1893676.

Keywords: regression
Regressed by: 1893676

Hiding the preview when a tab is clicked was never the intended behavior; I'll have to take a look at the regression range to see what happened. We can make it work either way.

Flags: needinfo?(dwalker)

Misha says clicking the background tab should dismiss both the preview screenshot and title (like Chrome does).

You need to log in before you can comment on or make changes to this bug.