1900892 - Build out archive encryption mechanism for single-file backup archives

Status: RESOLVED FIXED

(Firefox :: Profile Backup, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

This covers adding the mechanism for encrypting backup archives, but does not yet add the hooks that perform the encryption of backups. This will instead come in a follow-up bug.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1900892 - Part 1: Factor out computeBackupKeys to ArchiveUtils. r?djackson!

Factoring this out, as computing these keys is something that we need to do both
when generating the ArchiveEncryptionState, as well as when performing a
decryption.

This also renames "authKey" and "encKey" in ArchiveEncryptionState to use
"backupAuthKey" and "backupEncKey", as these are more in-line with what the
encryption design document uses (and because there are "authKeys" and "encKeys"
that will be used by the encryption mechanism that are distinct from the
backupAuthKey and backupEncKey).

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1900892 - Part 2: Define a ArchiveJSONBlock schema for the JSON block in a backup archive. r?#backup-reviewers!

Since the ArchiveJSONBlock uses a $ref to reference the metadata in the
BackupManifest schema, we have to change the JSON validation mechanism
we're using to one that supports $ref's.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1900892 - Part 3: Add ArchiveEncryptor and ArchiveDecryptor. r?djackson!

These classes allow us to encrypt and decrypt chunks of a backup archive
if encryption is enabled.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e043ded7c3f4
Part 1: Factor out computeBackupKeys to ArchiveUtils. r=djackson,backup-reviewers,kpatenio
https://hg.mozilla.org/integration/autoland/rev/a9b3bd5abdd2
Part 2: Define a ArchiveJSONBlock schema for the JSON block in a backup archive. r=backup-reviewers,fchasen
https://hg.mozilla.org/integration/autoland/rev/3639c8341f69
Part 3: Add ArchiveEncryptor and ArchiveDecryptor. r=djackson,backup-reviewers,kpatenio

Comment 5

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/e043ded7c3f4
https://hg.mozilla.org/mozilla-central/rev/a9b3bd5abdd2
https://hg.mozilla.org/mozilla-central/rev/3639c8341f69