Closed Bug 1900909 Opened 1 year ago Closed 1 year ago

elm_rebase.sh should restore the patch-stack prior to calling verify_vendoring

Categories

(Core :: WebRTC, defect, P2)

defect

Tracking

()

RESOLVED FIXED
129 Branch
Tracking Status
firefox129 --- fixed

People

(Reporter: mjf, Assigned: mjf)

Details

Attachments

(1 file)

There are 2 cases to consider:

  1. On starting elm_rebase.sh, we should restore/verify the patch-stack to make sure that no late fix-commits need to be added to the patch-stack. If not done, this can make the guidance presented at the end of the rebase process incorrect.
  2. We can run into a case where mozilla-central has changes from cherry-picked patches that add no-op-cherry-pick-msg files, but following the guidance at the end of the rebase deletes those files because they were not present in the state directory. Restoring the patch-stack will make sure those files are in the state directory in case the ending guidance requires saving the patch-stack.
Pushed by mfroman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e52374c35e37 call restore/verify on the patch-stack at beginning and end of elm_rebase.sh r=dbaker DONTBUILD
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: