1901057 - New search config isn't sending the "search-with" ping to glean

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[Mike Kaply [:mkaply] (PTO until Sept 14)]

It appears that with the v2 search rollout, we are not sending the clickUrl to Admarketplace

https://searchfox.org/mozilla-central/source/browser/components/search/BrowserSearchTelemetry.sys.mjs#185

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1901057 - Fix sending the search-with ping with search-config-v2 and remote overrides set. r?mkaply!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34c55958f5da
Fix sending the search-with ping with search-config-v2 and remote overrides set. r=mkaply,search-reviewers,mcheang

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1901057 - Fix sending the search-with ping with search-config-v2 and remote overrides set. r?mkaply!

Original Revision: https://phabricator.services.mozilla.com/D212824

Comment 4

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: None, search-with attribution will now work correctly.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: QA have steps
• Risk associated with taking this patch: Low
• Explanation of risk level: Fixes a missed addition of a property to a search engine object. Simple addition with null check.
• String changes made/needed: None
• Is Android affected?: no

Comment 5

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/cfd3e02d8411

Comment 6

[Adrian Florinescu [:aflorinescu]]

Verified the search-with glean telemetry ping for search-v2 with the try build :standard8 provided. Ping is recorded using the try build with both v1 and v2 search versions.

We'll redo the verification once 127RC with the fix is available.

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/34c55958f5da

Comment 8

[Adrian Florinescu [:aflorinescu]]

Verified the search-with glean telemetry ping for search-v2 with 127.0 RC2. Ping is recorded with both v1 and v2 search versions.

Comment 9

[Adrian Florinescu [:aflorinescu]]

Verified the search-with glean telemetry ping for search-v2 with 128.0b8 and 129.0a1 (2024-06-26). The dashboard for search-with reporting numbers that reached the "before incident all time high".