1901064 - Preserve user activation for window.open cases when fission is disabled

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Jan Jaeschke [:jjaschke]]

While implementing Bug 1888756 it became clear that window.open() calls do not preserve the user activation across process boundaries when fission is disabled.

Comment 1

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1901064, part 1 - Preserve user activation when Fission is disabled. r=edgar!,#dom-core

The code path that was used for loading a document
with fission disabled did not take user activation into account.
This made almost all WPTs for Text Fragments fail,
since they depend on this flag to decide if
a text directive is allowed to be scrolled to.

This patch makes sure that the user activation is
also available for code paths that run through
CanonicalBrowsingContext::FixupAndLoadURIString()
to load a document.

This is done by adding a flag hasValidUserGestureActivation
to the nsIOpenWindowInfo, which carries it through
the JS stack for loading a document.

Comment 2

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1901064, part 2 - Reactivate failing tests for Text Fragments that failed with Fission disabled. r=edgar!,#dom-core

Comment 3

[Jan Jaeschke [:jjaschke]]

Here's a try run.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/992a876144a0
part 1 - Preserve user activation when Fission is disabled. r=edgar,dom-core,tabbrowser-reviewers,mak,geckoview-reviewers,ohall
https://hg.mozilla.org/integration/autoland/rev/0e582d262ca8
part 2 - Reactivate failing tests for Text Fragments that failed with Fission disabled. r=edgar,dom-core

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/992a876144a0
https://hg.mozilla.org/mozilla-central/rev/0e582d262ca8

Comment 6

[Cristian Tuns]

Backed out for blocking the backout of Bug 1888756

• Backout link

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25b39ff6f118
part 1 - Preserve user activation when Fission is disabled. r=edgar,dom-core,tabbrowser-reviewers,mak,geckoview-reviewers,ohall
https://hg.mozilla.org/integration/autoland/rev/3db9c60ad0a3
part 2 - Reactivate failing tests for Text Fragments that failed with Fission disabled. r=edgar,dom-core

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/25b39ff6f118
https://hg.mozilla.org/mozilla-central/rev/3db9c60ad0a3