1901129 - Dragging a bookmark within the bookmarks tooblar makes other bookmarks bounce left and right

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[tgn-ff]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0

Steps to reproduce:

1. Make sure you have the bookmarks toolbar items visible and populated.
2. Try to move a bookmark or folder from one location to another by dragging it. This won't reproduce for items inside a folder.

Actual results:

The other items move back and forth as you hover over them with the bookmark you try to move.

Expected results:

Mozregresion points to either Bug 1900783 or Bug 1900784. I'll mark 1900783 as the regressor.

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e2739904da9469a32a83a90b534a860f5f427dd9&tochange=698a19071fd1cb07baa92f9c28d69a09e43e61ff

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:dao, since you are the author of the regressor, bug 1900783, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[tgn-ff]

Attachment: bookmark_moving.mp4

Comment 4

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Hello,
I am able to reproduce the issue on Firefox Nightly 128.0a1 (2024-06-06), using Windows 11, macOS 14.4 and Ubuntu 22.04, while following the steps from Comment 0.
I will mark this issue as NEW and update the flags in order to get our developers involved and provide a solution for this issue.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1900783

Comment 6

[Dão Gottwald [:dao]]

Attachment: Bug 1901129 - Restore #PlacesToolbarDropIndicatorHolder styling that was accidentally moved to #PlacesToolbarDropIndicator. r=emilio

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49b24ba77c90
Restore #PlacesToolbarDropIndicatorHolder styling that was accidentally moved to #PlacesToolbarDropIndicator. r=emilio,desktop-theme-reviewers

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/49b24ba77c90

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 9407866 [details]
Bug 1901129 - Restore #PlacesToolbarDropIndicatorHolder styling that was accidentally moved to #PlacesToolbarDropIndicator. r=emilio

Beta/Release Uplift Approval Request

• User impact if declined: See comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial CSS fix
• String changes made/needed:
• Is Android affected?: No

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9407866 [details]
Bug 1901129 - Restore #PlacesToolbarDropIndicatorHolder styling that was accidentally moved to #PlacesToolbarDropIndicator. r=emilio

Approved for 128.0b5.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/fac5140cb7fe

Comment 12

[Peter Magyari (Desktop QA)]

I have reproduced the issue on Nightly 129.0a1 (20240617085710) and verified the fix on Nightly 129.0a1 (20240620040816) and Beta 128.0b5 (20240619092300)