1901139 - The user activation state isn't propagted to nsDocShellLoadState for the load triggered by `window.open()`

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Description

[Edgar Chen [:edgar]]

We found this issue while working on Text Fragment (Bug 1888756).
window.open() will consume the user activation if the popup blocker is enabled. However, the nsDocShellLoadState is built after that, so it always ends up having mHasValidUserGestureActivation set to false. The popup blocker is disabled by default while running automation tests, so we didn't catch this issue during testing. And since only the Sec-Fetch-User use that currently, it is not easily noticeable by users. And the Text Fragment has made this issue emerge.

Comment 1

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=e8cc656b2594fb25140dbe67f2e0e051f76a1005

Comment 2

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=ad7153c4c8a600e2dcb4c7dde531166e8151239d

Comment 3

[Edgar Chen [:edgar]]

Attachment: Bug 1901139 - Stop replacing the URI of `nsDocShellLoadState` in `nsWindowWatcher::OpenWindowInternal`; r?#dom-core

nsWindowWatcher::OpenWindowInternal takes both a URL string and nsDocShellLoadState
as argument. In most of cases, caller passes null for nsDocShellLoadState and
nsWindowWatcher::OpenWindowInternal creates it lazily with the nsIURI which is
converted frome the URL string. The only place that passes both non-void URL string
and non-null nsDocShellLoadState is in nsDocShell::PerformRetargeting, see
https://searchfox.org/mozilla-central/rev/e74b86533c2499eb6393071aeedcfb080d84e4da/docshell/base/nsDocShell.cpp#8409.
The passed URL string is converted from the URI of the passed nsDocShellLoadState,
so they are actually equal. Therefore, the code for replacing URI is redundant.

Comment 4

[Edgar Chen [:edgar]]

Attachment: Bug 1901139 - Create nsDocShellLoadState before the transient user activaion is consumed; r?#dom-core!,ckerschb!

Depends on D215426

Comment 5

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=4405b48c588f69149fa55ebebe94956abcaafb4e

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49087840a161
Stop replacing the URI of `nsDocShellLoadState` in `nsWindowWatcher::OpenWindowInternal`; r=dom-core,peterv
https://hg.mozilla.org/integration/autoland/rev/5e76d2196972
Create nsDocShellLoadState before the transient user activaion is consumed; r=ckerschb,dom-core,peterv

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/49087840a161
https://hg.mozilla.org/mozilla-central/rev/5e76d2196972