Closed
Bug 1901144
Opened 7 months ago
Closed 7 months ago
Change nsLayoutUtils APIs that compute sizes to return results in Maybe
Categories
(Core :: Layout, task)
Core
Layout
Tracking
()
RESOLVED
FIXED
129 Branch
| Tracking | Status | |
|---|---|---|
| firefox129 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
Details
Attachments
(2 files)
In nsLayoutUtils, GetAbsoluteCoord, GetPercentBSize, GetDefiniteSize, GetIntrinsicCoord all return a bool indicating whether the result is computed successfully, with the actual results returned in output parameters. They could instead return Maybe<nscoord>.
|
Assignee | |
Comment 1•7 months ago
|
||
This patch doesn't change behavior.
|
||
Updated•7 months ago
|
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•7 months ago
|
||
This patch makes them match the naming of other APIs such as GetDefiniteSize
and GetPercentBSize.
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9635e5996cf9
Part 1 - Change nsLayoutUtils APIs that compute sizes to return results in Maybe. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/309981d70b62
Part 2 - Rename GetAbsoluteCoord and GetIntrinsicCoord. r=layout-reviewers,emilio
|
||
Comment 4•7 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9635e5996cf9
https://hg.mozilla.org/mozilla-central/rev/309981d70b62
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
status-firefox129:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•