1901160 - Incorrect level being set for kDefaultProfileLevelId

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P3)

Description

[Dan Baker[:dbaker]]

Currently if we receive an SDP for H264 without a profile-level-id attribute the profile-level-id will be set to 0x420010 this is for baseline with no constraints at a level 1.6 (not valid level). When no profile-level-id we need to set level to 1.0 the correct profile-level-id should be then 0x420000A.

Comment 1

[Dan Baker[:dbaker]]

Attachment: Bug 1901160 - Correcting level applied to kDefaultProfileLevelId for H264.;r?bwc

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8fb72129224
Correcting level applied to kDefaultProfileLevelId for H264.;r=bwc

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e8fb72129224

Comment 4

[Dan Baker[:dbaker]]

Comment on attachment 9406200 [details]
Bug 1901160 - Correcting level applied to kDefaultProfileLevelId for H264.;r?bwc

Beta/Release Uplift Approval Request

• User impact if declined: Crash in rare situations where H264 is used and there is no profile-level-id signaled.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We are simply correcting the default profile-level-id that we would apply if one is not signaled from 0x420010 to 0x42000A. Additionally testing was added to better test this default profile-level-id.
• String changes made/needed:
• Is Android affected?: Yes

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9406200 [details]
Bug 1901160 - Correcting level applied to kDefaultProfileLevelId for H264.;r?bwc

Approved for 128.0b4.

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2027d68f2e48