1901184 - Translations: Extraneous tab stop between Settings and Download all buttons

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[James Teh [:Jamie]]

(I wasn't sure whether to file this in the Translations component or the Settings component. Please move if necessary.)

STR (with the NVDA screen reader):

1. Open Firefox Settings.
2. Focus the Settings button for Translations.
3. Press tab.
   • Expected: Focus should move to the Download All button.
   • Actual: Focus moves to a div with id translations-manage-install-list and NVDA reads the entire content of this section: "Download languages for offline translation Download all button alt+shift+d Remove all alt+shift+e Bulgarian Download button ..."

This bug will go away once bug 1836304 is implemented. Until then, it's rather ugly. If bug 1836304 isn't likely to happen any time soon, I think this div needs tabindex="-1" so it doesn't get included in the tab order.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1901184 - The translations-manage-install-list div should not be keyboard focusable.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77519f95a80a
The translations-manage-install-list div should not be keyboard focusable. r=settings-reviewers,Gijs

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/77519f95a80a

Comment 4

[Simona Badau, Desktop QA]

Reproduced the initial issue on Nightly 128.0a1 (Build ID: 20240606092816) on Windows 10.

Verified the fix using Firefox 129.0b2 and Nightly 130.0a1 on Windows 10 x64. In step 3, the "Download all" button is now focused with NVDA reading, "Download all button, alt+shift+d."