Disable test devtools/client/responsive/test/browser/browser_target_blank.js timing out in over http2/http3
Categories
(DevTools :: Responsive Design Mode, defect)
Tracking
(firefox128 fixed, firefox129 fixed)
People
(Reporter: manuel, Assigned: manuel)
References
Details
Attachments
(2 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-beta+
|
Details | Review |
Both tests fail:
./mach mochitest --use-http2-server devtools/client/responsive/test/browser/browser_target_blank.js --headless
./mach mochitest --use-http3-server devtools/client/responsive/test/browser/browser_target_blank.js --headless
Assignee | ||
Comment 1•3 months ago
|
||
Updated•3 months ago
|
Assignee | ||
Comment 2•3 months ago
|
||
What was even weirder: The tests failed when ran individually, but succeeded when run as the full folder. ./mach mochitest --use-http3-server devtools/client/responsive/test/browser/
Afterwards they also failed when all tests ran. The reason for it was that we introduced an HTTPS-rr exception in with https://searchfox.org/mozilla-central/rev/d3fea1aa852bb3a353a0a4a875c3685da11ce39b/netwerk/protocol/http/nsHttpChannel.cpp#718 and not running the following tests with http3 at all, but using http1 (and http instead of https).
This is due to the incorrect redirect-loop detection and then adding a permanent exception to not make further upgrades via https-rr.
https://searchfox.org/mozilla-central/rev/d3fea1aa852bb3a353a0a4a875c3685da11ce39b/devtools/client/responsive/test/browser/browser_page_redirection.js#8
https://searchfox.org/mozilla-central/rev/d3fea1aa852bb3a353a0a4a875c3685da11ce39b/devtools/client/responsive/test/browser/sjs_redirection.sjs#20
Okay, I figured out why the test cases were starting to fail. They didn't run under http3 before. Will try to figure out which test cases to disable and which I can easily fix.
Updated•3 months ago
|
Updated•3 months ago
|
Pushed by mbucher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9c66fb97250b Fix test devtools/client/responsive/test/browser/ over http2/http3 (requiring https) r=devtools-reviewers,nchevobbe
Comment 4•3 months ago
|
||
bugherder |
Assignee | ||
Comment 5•3 months ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D212910
Updated•3 months ago
|
Updated•2 months ago
|
Updated•2 months ago
|
Description
•