1901413 - Hit MOZ_CRASH(invalid UTF-8 string: ReportInvalidCharacter) at /root/src/js/src/vm/CharacterEncoding.cpp:322

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Nils Bars]

Attachment: bug.js

Steps to reproduce:

Checkout commit 15778b8c32f8535624fff2af36fc669e65a9af3 and invoke the js shell as follows:

/root/js-spidermonkey-shell  --fuzzing-safe  <testcase>

Actual results:

Hit MOZ_CRASH(invalid UTF-8 string: ReportInvalidCharacter) at /root/src/js/src/vm/CharacterEncoding.cpp:322

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

The first bad revision is:
changeset:   https://hg.mozilla.org/mozilla-central/rev/11e79bc5149a
user:        Tooru Fujisawa
date:        Tue Jun 06 04:29:07 2023 +0000
summary:     Bug 1831845 - Part 1: Use JS::ConstUTF8CharsZ in JS::TransitiveCompileOptions::{filename_,introducerFilename_}. r=nbp

Arai-san, is bug 1831845 a likely regressor?

Comment 2

[Tooru Fujisawa [:arai]]

Yes, I overlooked the consumer with latin-1 in debugger.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1901413 - Use UTF-8 for Debugger.Object.createSource url parameter. r?iain!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c90c17a9f8a
Use UTF-8 for Debugger.Object.createSource url parameter. r=iain

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1831845

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0c90c17a9f8a

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:arai, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox128 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1901413 - Use UTF-8 for Debugger.Object.createSource url parameter. r?iain!

Original Revision: https://phabricator.services.mozilla.com/D213057

Comment 9

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Possible crash when non-ASCII/non-UTF-8 filename flows into debugger
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: None
• Risk associated with taking this patch: Low
• Explanation of risk level: This changes the behavior only when the filename is non-ASCII, which doesn't happen in general for web, given URLs are all URL-encoded ASCII
• String changes made/needed: None
• Is Android affected?: yes

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/aa3043f6c8da