1901455 - leparisien.fr - Translation doesn't affect overlay element

Status: RESOLVED INVALID

(Firefox :: Translations, defect)

Description

[u752148]

Steps to reproduce:

• Go to https://www.leparisien.fr/
• Allow Firefox to translate it from French

Actual results:

The overlay/modal/"popup" element about cookies isn't translated.

I don't know what the French will do to me if I click on Accepter.

Expected results:

Firefox should protect me from the French.

Comment 1

[Greg Tatum [:gregtatum] (REO Fx132)]

The popup has the notranslate class, so it's due to the implementation of the webpage, not because of the translation engine. The behavior is the same in other browsers. I was going to close this as invalid as it's correct behavior, and suggest using select translation, but I notice that select translation doesn't actually work in this case.

:nordzilla what do you think about this edge case? I would still like to select translate on a "notranslate" div, but the context menu is disabled after I have translated the page.

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: image.png

This is an interesting scenario. I'll try to break down all of the considerations that went into this and we can have a discussion about this.

---

Why we do not allow Select Translations Panel (STP) while Full Page Translations (FPT) is active

Firstly, I should mention that there isn't any technical reason why we cannot do this. In fact, I've disabled the restriction in my local build of the code and then used STP to translate the example here while FPT was active too (see attached screenshot).

But STP is currently disabled in this scenario for a few reasons, based on my recollection:

1. When Dasha and I first looked at this, we considered what other browsers do as part of the decision here. I thought that we had discovered that some other browsers do not allow Select Translation while Full Page Translation is active, but I just tried this exact scenario in Chrome and Safari and was able to do it.

2. Another consideration if this were allowed is that in most cases (but not this case), the selected text would give you a translation of a translation, which will not always produce the highest-quality result.

3. There is also the question of what to do with the "Translate full page" button within the STP while Full Page Translation (FPT) is already active. For example, if I translate a page from French to German, and then I translate a selection of the translated-from-French German text to Spanish, then the state of my STP would be German to Spanish. This is fine within the context of the STP, however clicking the "Translate full page" button would then attempt to translate a French page using a German-to-Spanish translation model, resulting in garbage.

---

Conclusion

Overall, however, I'm thinking that we should revisit our decision to disallow STP while FPT is active, particularly because it is useful in scenarios such as this one.

I think the best behavior here may actually be to allow STP in this scenario, but either disable or entirely hide the "Translate full page" button if Full Page Translation is already active.

I think it would be too late to get this into Firefox 128, but I think that we could implement this for Firefox 129.

@Dasha @Greg thoughts?

Comment 3

[Dasha Andriyenko [:Dasha]]

Thanks for the overview [:nordzilla]
I agree with you! I recall us chatting about it being a bit weird in some instances (in particular the quality being off) but it seems like there are some instances where this would be super useful.

In summary, I agree that we should:

• Allow STP in FPT
• IMO "Translate full page" button should be disabled (if the users's STP output language matches the FPT output language.). However, if the user changes the output language in STP to be something else, then the button should become enabled and allow them to do a FPT with a different output. But, if we don't feel confident about being able to do a secondary FPT if another output language is chosen, then we can just remove this button from this view. Let me know what y'all think about this.

Comment 4

[Erik Nordin [:nordzilla]]

• IMO "Translate full page" button should be disabled (if the users's STP output language matches the FPT output language.). However, if the user changes the output language in STP to be something else, then the button should become enabled and allow them to do a FPT with a different output. But, if we don't feel confident about being able to do a secondary FPT if another output language is chosen, then we can just remove this button from this view. Let me know what y'all think about this.

The problem with ever allowing FPT in this state is the from-language would have to match the document's original content for it to function correctly.

When you change the to-language from the FPT revisit view, it doesn't "re-translate the current translation," it goes back to the source content and then translates it to your new target.

So, for example, if we:

1. Use FPT to translate a Spanish page into German
2. Then use STP to translate German text to French
3. Then change the STP-to-language to Ukrainian

If we enabled the full-page-translations button here, we would end up translating a Spanish content site, fed through our German-to-Ukrainian models, which would result in a garbage translation.

---

The only possible way we could enable the button in this state, is if we ignored the STP's currently selected from-language value, and instead translated from the document-language to the SPT-to-language value to re-translate the page.

We could do this, though I'm not sure if it would be confusing for users, since when FPT is not active, it does take the SPT-from-language value into consideration.

Comment 5

[Dasha Andriyenko [:Dasha]]

Ok, since it will become quite confusing/ more complicated, I agree with you Eirk, that we should remove the "Translate full page" button from the SPT panel during this state. It makes the path more simple.

Comment 6

[Erik Nordin [:nordzilla]]

I've filed Bug 1904355 specifically for this and linked it to the Select Translations MVP Follow-Ups Meta Bug.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:nordzilla, could you have a look please?

For more information, please visit BugBot documentation.

Comment 8

[Erik Nordin [:nordzilla]]

I'm going to re-mark this as RESOLVED INVALID, given that Full Page Translations should continue to respect the notranslate tag.

However, we do now have Bug 1904355 that will allow Select Translations on top of Full Page Translations.

Comment 9

[Erik Nordin [:nordzilla]]

Hi kakekikoku,

I just wanted to update you that Bug 1904355 has landed.

In Nightly Firefox, you should now be able to try the functionality of translating this popup text by highlighting it, right-clicking and choosing "Translate Selection to..." from the context menu, even while Full-Page Translations is actively translating the rest of the page.