1901464 - [UIA] Implement ITextProvider::GetVisibleRanges

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

This will allow UIA clients to determine text that is currently visible on screen.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1901464 part 1: TextLeafRange::WalkLineRects: Pass the TextLeafRange for each line to the callback.

This will be used in a subsequent patch to fetch the sub-ranges for visible lines.

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1901464 part 2: Refactor UiaText code to convert an array of TextLeafRanges to a SAFEARRAY of UiaTextRanges into a utility function.

This is currently only used by GetSelection, but it will be used by GetVisibleRanges in a subsequent patch.
There is a slight functionality change here: if there are no ranges, this returns an empty array.
GetSelection is unclear about what should be done here, but the documentation for GetVisibleRanges explicitly states an empty array should be returned, so that's what we do.
GetSelection previously left the SAFEARRAY pointer uninitialised in this case, which is definitely nasty and unsafe.

Comment 3

[James Teh [:Jamie]]

Attachment: Bug 1901464 part 3: Implement ITextProvider::GetVisibleRanges.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b38ef52a5079
part 1: TextLeafRange::WalkLineRects: Pass the TextLeafRange for each line to the callback. r=nlapre
https://hg.mozilla.org/integration/autoland/rev/1b0d7e5377bb
part 2: Refactor UiaText code to convert an array of TextLeafRanges to a SAFEARRAY of UiaTextRanges into a utility function. r=nlapre
https://hg.mozilla.org/integration/autoland/rev/e63c3cb08527
part 3: Implement ITextProvider::GetVisibleRanges. r=nlapre

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/b38ef52a5079
https://hg.mozilla.org/mozilla-central/rev/1b0d7e5377bb
https://hg.mozilla.org/mozilla-central/rev/e63c3cb08527