1901534 - Compute a new enc-state.json for the recovered profile after recovery

Status: RESOLVED FIXED

(Firefox :: Profile Backup, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

If an encrypted backup is recovered from, this implies that encryption was enabled when the backup was created - and that scheduled backups were also enabled. In order to continue that behaviour in the recovered profile, we'll need an enc-state.json in the backup folder of the recovered profile.

The problem, however, is that the OSKeyStoreSecret might not be the same on the machine that the backup was recovered on! We'll need to generate a new one. We can do this with the passed in recovery code as part of the restoration, in the profile that is performing the restoration, before launching the new profile.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1901534 - Compute a new ArchiveEncryptionState for a recovered, encrypted profile. r?#backup-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e494cb0aff6
Compute a new ArchiveEncryptionState for a recovered, encrypted profile. r=backup-reviewers,fchasen

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures @ test_BackupService_renderTemplate.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/ba3427ddddb6b457ba8ab233bc0e6506aa9bc350

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/backup/tests/xpcshell/test_BackupService_renderTemplate.js | xpcshell return code: 1

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35124ba24398
Compute a new ArchiveEncryptionState for a recovered, encrypted profile. r=backup-reviewers,fchasen

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/35124ba24398