1901538 - Add the ability to "decorate" the user's backup destination folder

Status: NEW

(Firefox :: Shell Integration, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

On at least Windows and macOS, it is possible to get the native file pickers to show custom icons for folders. This bug is about doing that for the backup folder that gets created under the user's selected backup destination directory.

The icons aren't yet available, but we should build out and test the technique for creating these kinds of folders.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Details on the icons that are expected for Win32 applications: https://learn.microsoft.com/en-us/windows/win32/uxguide/vis-icons

for macOS: https://manik.cc/2020/05/21/macicons.html

for Linux (GNOME): https://github.com/kevinboone/gnome-set-folder-icon

Comment 2

[Nick Alexander :nalexander [he/him] (PTO August 22-September 12)]

For Windows:

Relevant docs at https://learn.microsoft.com/en-ca/windows/win32/shell/how-to-customize-folders-with-desktop-ini?redirectedfrom=MSDN. This seems straight-forward. It would be nice to put it in the (Windows) Shell Service impl but otherwise I’d write it in JS and call it a day.

So:

• configure folder to be system;
• write icon .ico;
• write desktop.ini;
• configure desktop.ini to be system, hidden

Setting the Windows bits is already accommodated, see https://searchfox.org/mozilla-central/rev/2f48061aef8c8976b73749ee845e7b85751f5f2f/dom/chrome-webidl/IOUtils.webidl#704-717. There’s support for writing INI files: https://searchfox.org/mozilla-central/rev/2f48061aef8c8976b73749ee845e7b85751f5f2f/xpcom/ds/nsIINIParser.idl#35. Writing the .ico might be the most interesting part, but if we don't need to generate the icon then I expect it’s easy to dump one from the package onto disk. Writing a relative .ico is important so that you can move the folder around.

Comment 3

[Duncan McIntosh [:dmcintosh]]

Quick note that some support for desktop.ini was added to change the display name in bug 1998967, so all that should be left is copying the icon and adding IconFile to desktop.ini.