Closed Bug 1901566 Opened 17 days ago Closed 13 days ago

[wpt-sync] Sync PR 46674 - Fix table track offsets when there is `visibility: collapse`

Categories

(Core :: Layout: Tables, task, P4)

Product:
Core
Component:
Layout: Tables
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
129 Branch
Tracking Flags:
Tracking Status
firefox129 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 46674 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46674
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

Fix table track offsets when there is visibility: collapse

Each non-collapsed track used to increase the offset by the subsequent border spacing. Now they will take care of their preceding spacing instead.

This way, if a cell spans two rows, and the second is collapsed, the cell won't be forced to be at least as tall as the border spacing. This matches Gecko and Blink (WebKit lacks visibility: collapse).

This makes visibility-collapse-border-spacing-001.html fail because we generate outlines in a different way than Blink. Gecko also fails it in a similar (but different) way.

<!-- Please describe your changes on the following line: -->

Reviewed in servo/servo#32469

Component: web-platform-tests → Layout: Tables
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

PASS: 2

Safari

FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a44554f8cd3f
[wpt PR 46674] - Fix table track offsets when there is `visibility: collapse`, a=testonly
https://hg.mozilla.org/integration/autoland/rev/8ae9678914cf
[wpt PR 46674] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a44554f8cd3f
https://hg.mozilla.org/mozilla-central/rev/8ae9678914cf

Status: NEW → RESOLVED
Closed: 13 days ago
status-firefox129: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in before you can comment on or make changes to this bug.