1901667 - Intermittent services/fxaccounts/tests/xpcshell/test_commands_closetab.js | single tracking bug

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: tszentpeteri [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=461764723&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/RcWdLMlSRzmHKDASrPHOkQ/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/RcWdLMlSRzmHKDASrPHOkQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2024-06-10T23:06:06.344Z] 23:06:06     INFO -  TEST-START | services/fxaccounts/tests/xpcshell/test_commands_closetab.js
[task 2024-06-10T23:06:06.979Z] 23:06:06  WARNING -  TEST-UNEXPECTED-FAIL | services/fxaccounts/tests/xpcshell/test_commands_closetab.js | xpcshell return code: 0
[task 2024-06-10T23:06:06.979Z] 23:06:06     INFO -  TEST-INFO took 627ms
[task 2024-06-10T23:06:06.979Z] 23:06:06     INFO -  >>>>>>>
[task 2024-06-10T23:06:06.979Z] 23:06:06     INFO -  PID 5328 | *** You are running in chaos test mode. See ChaosMode.h. ***
[task 2024-06-10T23:06:06.979Z] 23:06:06     INFO -  PID 5328 | [Parent 5328, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:2888
[task 2024-06-10T23:06:06.979Z] 23:06:06     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2024-06-10T23:06:06.979Z] 23:06:06     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2024-06-10T23:06:06.979Z] 23:06:06     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2024-06-10T23:06:06.979Z] 23:06:06     INFO -  running event loop
[task 2024-06-10T23:06:06.979Z] 23:06:06     INFO -  services/fxaccounts/tests/xpcshell/test_commands_closetab.js | Starting test_closetab_isDeviceCompatible
[task 2024-06-10T23:06:06.979Z] 23:06:06     INFO -  (xpcshell/head.js) | test test_closetab_isDeviceCompatible pending (2)
[task 2024-06-10T23:06:06.979Z] 23:06:06     INFO -  PID 5328 | 1718060766642	FirefoxAccounts	TRACE	CloseRemoteTab observer created
[task 2024-06-10T23:06:06.979Z] 23:06:06     INFO -  TEST-PASS | services/fxaccounts/tests/xpcshell/test_commands_closetab.js | test_closetab_isDeviceCompatible - [test_closetab_isDeviceCompatible : 50] true == true

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:skhamis, since you are the author of the regressor, bug 1892340, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1892340

Comment 3

[Intermittent Failures Robot]

15 failures in 1038 pushes (0.014 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 11
• try: 2
• autoland: 2

Platform and build breakdown:

• linux1804-64-tsan-qr: 3
  • opt: 3
• linux1804-64-ccov-qr: 5
  • opt: 5
• linux1804-64-qr: 5
  • debug: 4
  • opt: 1
• linux1804-64-asan-qr: 1
  • opt: 1
• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1901667&startday=2024-06-12&endday=2024-06-12&tree=all

Comment 4

[Intermittent Failures Robot]

15 failures in 869 pushes (0.017 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 8
• mozilla-central: 5
• try: 2

Platform and build breakdown:

• linux1804-64-tsan-qr: 6
  • opt: 6
• linux1804-64-qr: 5
  • debug: 4
  • opt: 1
• linux1804-64-ccov-qr: 1
  • opt: 1
• linux1804-64-shippable-qr: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1901667&startday=2024-06-14&endday=2024-06-14&tree=all

Comment 5

[Intermittent Failures Robot]

63 failures in 4625 pushes (0.014 failures/push) were associated with this bug in the last 7 days.

This is the #20 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 17
• mozilla-central: 35
• try: 11

Platform and build breakdown:

• linux1804-64-qr: 18
  • debug: 14
  • opt: 4
• linux1804-64-asan-qr: 4
  • opt: 4
• linux1804-64-tsan-qr: 17
  • opt: 17
• linux1804-64-shippable-qr: 13
  • opt: 13
• linux1804-64-ccov-qr: 10
  • opt: 10
• linux1804-64-devedition-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1901667&startday=2024-06-10&endday=2024-06-16&tree=all

Comment 6

[Sammy Khamis [:skhamis]]

Attachment: Bug 1901667: Fix Intermittent test_commands_closetab.js failures r?lina,markh

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9cbdae9215d2
Fix Intermittent test_commands_closetab.js failures r=markh

Comment 8

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/9cbdae9215d2

Comment 9

[Intermittent Failures Robot]

25 failures in 939 pushes (0.027 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 11
• mozilla-central: 12
• try: 2

Platform and build breakdown:

• windows11-32-2009-qr: 3
  • opt: 3
• windows11-64-2009-qr: 3
  • opt: 3
• linux1804-64-shippable-qr: 3
  • opt: 3
• windows11-64-2009-shippable-qr: 1
  • opt: 1
• windows11-32-2009-shippable-qr: 1
  • opt: 1
• linux1804-64-ccov-qr: 5
  • opt: 5
• linux1804-64-asan-qr: 2
  • opt: 2
• linux1804-64-qr: 3
  • debug: 3
• linux1804-64-tsan-qr: 4
  • opt: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1901667&startday=2024-06-18&endday=2024-06-18&tree=all

Comment 10

[Iulian Moraru]

Backed out for causing xpcshell failures on test_commands_closetab.js.

• Push with failures

• Failure log

• Backout link

[task 2024-06-19T06:09:03.841Z] 06:09:03     INFO -  TEST-START | services/fxaccounts/tests/xpcshell/test_commands_closetab.js
[task 2024-06-19T06:09:04.223Z] 06:09:04  WARNING -  TEST-UNEXPECTED-FAIL | services/fxaccounts/tests/xpcshell/test_commands_closetab.js | xpcshell return code: 0
[task 2024-06-19T06:09:04.229Z] 06:09:04     INFO -  TEST-INFO took 382ms
[task 2024-06-19T06:09:04.229Z] 06:09:04     INFO -  >>>>>>>
[task 2024-06-19T06:09:04.229Z] 06:09:04     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2024-06-19T06:09:04.229Z] 06:09:04     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2024-06-19T06:09:04.230Z] 06:09:04     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2024-06-19T06:09:04.230Z] 06:09:04     INFO -  running event loop
[task 2024-06-19T06:09:04.230Z] 06:09:04     INFO -  services/fxaccounts/tests/xpcshell/test_commands_closetab.js | Starting test_closetab_isDeviceCompatible
[task 2024-06-19T06:09:04.230Z] 06:09:04     INFO -  (xpcshell/head.js) | test test_closetab_isDeviceCompatible pending (2)
[task 2024-06-19T06:09:04.231Z] 06:09:04     INFO -  PID 2848 | 1718777344163	FirefoxAccounts	TRACE	CloseRemoteTab observer created
[task 2024-06-19T06:09:04.231Z] 06:09:04     INFO -  TEST-PASS | services/fxaccounts/tests/xpcshell/test_commands_closetab.js | test_closetab_isDeviceCompatible - [test_closetab_isDeviceCompatible : 50] true == true
[task 2024-06-19T06:09:04.232Z] 06:09:04     INFO -  TEST-PASS | services/fxaccounts/tests/xpcshell/test_commands_closetab.js | test_closetab_isDeviceCompatible - [test_closetab_isDeviceCompatible : 52] true == true
[task 2024-06-19T06:09:04.232Z] 06:09:04     INFO -  TEST-PASS | services/fxaccounts/tests/xpcshell/test_commands_closetab.js | test_closetab_isDeviceCompatible - [test_closetab_isDeviceCompatible : 61] true == true
[task 2024-06-19T06:09:04.233Z] 06:09:04     INFO -  TEST-PASS | services/fxaccounts/tests/xpcshell/test_commands_closetab.js | test_closetab_isDeviceCompatible - [test_closetab_isDeviceCompatible : 68] "payload" == true
[task 2024-06-19T06:09:04.233Z] 06:09:04     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2024-06-19T06:09:04.233Z] 06:09:04     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2024-06-19T06:09:04.233Z] 06:09:04     INFO -  (xpcshell/head.js) | test test_closetab_isDeviceCompatible finished (2)
[task 2024-06-19T06:09:04.234Z] 06:09:04     INFO -  services/fxaccounts/tests/xpcshell/test_commands_closetab.js | Starting test_closetab_send
[task 2024-06-19T06:09:04.234Z] 06:09:04     INFO -  (xpcshell/head.js) | test test_closetab_send pending (2)
[task 2024-06-19T06:09:04.234Z] 06:09:04     INFO -  PID 2848 | 1718777344165	FirefoxAccounts	TRACE	CloseRemoteTab observer created
[task 2024-06-19T06:09:04.234Z] 06:09:04     INFO -  (xpcshell/head.js) | test run_next_test 1 finished (2)
[task 2024-06-19T06:09:04.235Z] 06:09:04     INFO -  TEST-PASS | services/fxaccounts/tests/xpcshell/test_commands_closetab.js | test_closetab_send - [test_closetab_send : 109] adding the remote command should work - true == true
<...>
[task 2024-06-19T06:09:04.252Z] 06:09:04     INFO -  TEST-PASS | services/fxaccounts/tests/xpcshell/test_commands_closetab.js | test_timer_reset_on_new_tab - [test_timer_reset_on_new_tab : 265] true == true
[task 2024-06-19T06:09:04.252Z] 06:09:04     INFO -  (xpcshell/head.js) | test run_next_test 4 pending (2)
[task 2024-06-19T06:09:04.252Z] 06:09:04     INFO -  (xpcshell/head.js) | test test_timer_reset_on_new_tab finished (2)
[task 2024-06-19T06:09:04.253Z] 06:09:04     INFO -  services/fxaccounts/tests/xpcshell/test_commands_closetab.js | Starting test_telemetry_on_sendCloseTabPush
[task 2024-06-19T06:09:04.253Z] 06:09:04     INFO -  (xpcshell/head.js) | test test_telemetry_on_sendCloseTabPush pending (2)
[task 2024-06-19T06:09:04.253Z] 06:09:04     INFO -  PID 2848 | 1718777344202	FirefoxAccounts	TRACE	CloseRemoteTab observer created
[task 2024-06-19T06:09:04.253Z] 06:09:04     INFO -  (xpcshell/head.js) | test run_next_test 4 finished (2)
[task 2024-06-19T06:09:04.254Z] 06:09:04     INFO -  PID 2848 | 1718777344203	FirefoxAccounts	TRACE	flushQueue total queued items: 2
[task 2024-06-19T06:09:04.255Z] 06:09:04     INFO -  PID 2848 | 1718777344204	FirefoxAccounts	TRACE	command for url https://foo.bar/ was queued for sending 0.011s ago, so sending it now
[task 2024-06-19T06:09:04.255Z] 06:09:04     INFO -  PID 2848 | 1718777344204	FirefoxAccounts	TRACE	command for url https://example.com/ was queued for sending 0.006s ago, so ensuring the next timer is set for it.
[task 2024-06-19T06:09:04.255Z] 06:09:04     INFO -  PID 2848 | 1718777344204	FirefoxAccounts	INFO	Sending tab closures to dev1 device.
[task 2024-06-19T06:09:04.255Z] 06:09:04     INFO -  PID 2848 | 1718777344204	FirefoxAccounts	TRACE	Setting pending command for device dev1 as sent: {"deviceId":"dev1","command":{"url":"https://foo.bar/"},"timeRequested":1718777344192,"timeSent":null}
[task 2024-06-19T06:09:04.256Z] 06:09:04     INFO -  PID 2848 | 1718777344205	FirefoxAccounts	INFO	Setting a new close-tab timer with delay=14 with existing timer=false
[task 2024-06-19T06:09:04.256Z] 06:09:04     INFO -  PID 2848 | 1718777344205	FirefoxAccounts	TRACE	flushQueue total queued items: 1
[task 2024-06-19T06:09:04.256Z] 06:09:04     INFO -  PID 2848 | 1718777344206	FirefoxAccounts	TRACE	command for url https://example.com/ was queued for sending 0.026s ago, so sending it now
[task 2024-06-19T06:09:04.257Z] 06:09:04     INFO -  PID 2848 | 1718777344206	FirefoxAccounts	INFO	Sending tab closures to dev1 device.
[task 2024-06-19T06:09:04.257Z] 06:09:04     INFO -  PID 2848 | 1718777344206	FirefoxAccounts	TRACE	Setting pending command for device dev1 as sent: {"deviceId":"dev1","command":{"url":"https://example.com/"},"timeRequested":1718777344197,"timeSent":null}
[task 2024-06-19T06:09:04.257Z] 06:09:04     INFO -  PID 2848 | 1718777344207	FirefoxAccounts	INFO	No new close-tab timer needed because there's nothing to do
[task 2024-06-19T06:09:04.258Z] 06:09:04  WARNING -  TEST-UNEXPECTED-FAIL | services/fxaccounts/tests/xpcshell/test_commands_closetab.js | test_telemetry_on_sendCloseTabPush - [test_telemetry_on_sendCloseTabPush : 309] [{"object":"command-sent","method":"close-uri/v1","value":"dev1-san","extra":{"flowID":"1","streamID":"2"}},{"object":"command-sent","method":"close-uri/v1","value":"dev1-san","extra":{"flowID":"3","streamID":"4"}}] deepEqual [{"object":"command-sent","method":"close-uri/v1","value":"dev1-san","extra":{"flowID":"1","streamID":"2"}}]
[task 2024-06-19T06:09:04.258Z] 06:09:04     INFO -  D:/task_171877393676294/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_commands_closetab.js:test_telemetry_on_sendCloseTabPush:309
[task 2024-06-19T06:09:04.258Z] 06:09:04     INFO -  D:\task_171877393676294\build\tests\xpcshell\head.js:_do_main:245
[task 2024-06-19T06:09:04.259Z] 06:09:04     INFO -  D:\task_171877393676294\build\tests\xpcshell\head.js:_execute_test:596
[task 2024-06-19T06:09:04.260Z] 06:09:04     INFO -  -e:null:1
[task 2024-06-19T06:09:04.260Z] 06:09:04     INFO -  exiting test
[task 2024-06-19T06:09:04.260Z] 06:09:04     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2024-06-19T06:09:04.260Z] 06:09:04     INFO -  _abort_failed_test@D:\task_171877393676294\build\tests\xpcshell\head.js:869:20
[task 2024-06-19T06:09:04.260Z] 06:09:04     INFO -  do_report_result@D:\task_171877393676294\build\tests\xpcshell\head.js:981:5
[task 2024-06-19T06:09:04.261Z] 06:09:04     INFO -  Assert<@D:\task_171877393676294\build\tests\xpcshell\head.js:70:21
[task 2024-06-19T06:09:04.261Z] 06:09:04     INFO -  Assert.prototype.report@resource://testing-common/Assert.sys.mjs:251:10
[task 2024-06-19T06:09:04.261Z] 06:09:04     INFO -  deepEqual@resource://testing-common/Assert.sys.mjs:331:8
[task 2024-06-19T06:09:04.261Z] 06:09:04     INFO -  test_telemetry_on_sendCloseTabPush@D:/task_171877393676294/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_commands_closetab.js:309:10
[task 2024-06-19T06:09:04.262Z] 06:09:04     INFO -  _do_main@D:\task_171877393676294\build\tests\xpcshell\head.js:245:6
[task 2024-06-19T06:09:04.262Z] 06:09:04     INFO -  _execute_test@D:\task_171877393676294\build\tests\xpcshell\head.js:596:5
[task 2024-06-19T06:09:04.262Z] 06:09:04     INFO -  @-e:1:1
[task 2024-06-19T06:09:04.262Z] 06:09:04     INFO -  exiting test
[task 2024-06-19T06:09:04.263Z] 06:09:04     INFO -  <<<<<<<
[task 2024-06-19T06:09:04.263Z] 06:09:04     INFO -  TEST-START | dom/push/test/xpcshell/test_unregister_invalid_json.js

Comment 11

[Iulian Moraru]

After the patch landed this started permafailing: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=HLx0XqmWTsau12f4qUSq8A.0&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&searchStr=xpcshell&revision=1a2ecf71fee5c1e91671bb079d21d5ef15b57084 and the failure line changed to TEST-UNEXPECTED-FAIL | services/fxaccounts/tests/xpcshell/test_commands_closetab.js | test_telemetry_on_sendCloseTabPush - [test_telemetry_on_sendCloseTabPush : 309] [{"object":"command-sent","method":"close-uri/v1","value":"dev1-san","extra":{"flowID":"1","streamID":"2"}},{"object":"command-sent","method":"close-uri/v1","value":"dev1-san","extra":{"flowID":"3","streamID":"4"}}] deepEqual [{"object":"command-sent","method":"close-uri/v1","value":"dev1-san","extra":{"flowID":"1","streamID":"2"}}]

Hi Sammy! Can you please take another look at this?
Thank you!

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1892340

Comment 13

[Iulian Moraru]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/a65d3114810a

Comment 14

[Intermittent Failures Robot]

18 failures in 883 pushes (0.02 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 14
• mozilla-central: 4

Platform and build breakdown:

• windows11-32-2009-qr: 2
  • opt: 2
• windows11-64-2009-qr: 2
  • opt: 2
• windows10-64-2009-qr: 1
  • opt: 1
• linux1804-64-ccov-qr: 2
  • opt: 2
• linux1804-64-qr: 4
  • opt: 2
  • debug: 2
• macosx1015-64-qr: 1
  • debug: 1
• linux1804-64-asan-qr: 3
  • opt: 3
• linux1804-64-tsan-qr: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1901667&startday=2024-06-19&endday=2024-06-19&tree=all

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77cfb9a42476
Fix Intermittent test_commands_closetab.js failures r=markh

Comment 16

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/77cfb9a42476

Comment 17

[Intermittent Failures Robot]

67 failures in 4577 pushes (0.015 failures/push) were associated with this bug in the last 7 days.

This is the #33 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 30
• mozilla-central: 29
• try: 4
• comm-central: 1
• try-comm-central: 3

Platform and build breakdown:

• windows11-32-2009-qr: 5
  • opt: 5
• windows11-64-2009-qr: 5
  • opt: 5
• linux1804-64-shippable-qr: 7
  • opt: 7
• windows11-64-2009-shippable-qr: 1
  • opt: 1
• windows11-32-2009-shippable-qr: 1
  • opt: 1
• linux1804-64-qr: 16
  • debug: 11
  • opt: 5
• linux1804-64-tsan-qr: 16
  • opt: 16
• windows10-64-2009-qr: 1
  • opt: 1
• linux1804-64-ccov-qr: 9
  • opt: 9
• macosx1015-64-qr: 1
  • debug: 1
• linux1804-64-asan-qr: 5
  • opt: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1901667&startday=2024-06-17&endday=2024-06-23&tree=all