1901767 - PipeWire camera: add support for ARGB/ABGR formats

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement)

Description

[Robert Mader [:rmader]]

In order to work with the libcamera softwareISP (see https://patchwork.libcamera.org/patch/20253/)

Upstream CL: https://webrtc-review.googlesource.com/c/src/+/354400

Comment 1

[Robert Mader [:rmader]]

Attachment: WIP: Bug 1901767 - PipeWire camera: add support for ARGB/ABGR formats

Backport of https://webrtc-review.googlesource.com/c/src/+/354400

Comment 2

[Robert Mader [:rmader]]

Test build for aarch64: https://treeherder.mozilla.org/jobs?repo=try&revision=50f905f686e50e27eedceed36ef606b340040fa1

Comment 3

[Jan Grulich]

Attachment: Bug 1901767 - WebRTC backport: PipeWire camera - add support for BGRA/RGBA formats r=pehrsons

This is a simple backport of an WebRTC upstream change.

Upstream commit: c3aeffd776a22050aff43c81e4a61da3492fa821.

Comment 4

[Robert Mader [:rmader]]

For the record: it would be awesome to get this into the upcoming ESR 128 as mobile linux distros tend to use that (because of downstream mobile patches).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07e9c5a3c7f9
WebRTC backport: PipeWire camera - add support for BGRA/RGBA formats r=pehrsons,webrtc-reviewers

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/07e9c5a3c7f9

Comment 7

[Robert Mader [:rmader]]

Jan: do you agree that we should request a backport to beta / 128 (upcoming ESR) for all these patches?

Comment 8

[Jan Grulich]

(In reply to Robert Mader [:rmader] from comment #7)

Jan: do you agree that we should request a backport to beta / 128 (upcoming ESR) for all these patches?

Yes, I think we should do that.

Comment 9

[Jan Grulich]

Comment on attachment 9407475 [details]
Bug 1901767 - WebRTC backport: PipeWire camera - add support for BGRA/RGBA formats r=pehrsons

Beta/Release Uplift Approval Request

• User impact if declined: This is a set of simple WebRTC backports allowing to use PipeWire camera with libcamera software ISP. This is needed for laptops with Snapdragon chips. There is no risk backporting these patches, they are simple and straightforward and also PipeWire camera is not enabled by default in Firefox. Since the next Firefox 128 is an ESR release, we think it makes sense to include these fixes.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: 1902618 1902615
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): These patches are fairly trivial without having any potential side-effect. They were thoroughly tested.

This patch adds just two additional formats (enums) to the set of supported formats. Fix in 1902618 fixes arguments in mmap() call following the documentation and fix in 1902615 just filters out existing camera devices by searching in a map.

• String changes made/needed:
• Is Android affected?: No

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9407475 [details]
Bug 1901767 - WebRTC backport: PipeWire camera - add support for BGRA/RGBA formats r=pehrsons

Approved for 128.0b5.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/55787fdacdf2