1901771 - Refactor/Clean-up user characteristics code

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement, P3)

Description

[Fatih Kilic [:fkilic]]

Currently, the user characteristic code is a little cluttered. It would be nice if we could clean it up a little bit.

Comment 1

[Fatih Kilic [:fkilic]]

Attachment: Bug 1901771: Refactor user characteristics code. r?timhuang

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/507251dd379e
Refactor user characteristics code. r=timhuang

Comment 3

[Cristian Tuns]

Backed out for causing leakcheck failures

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | leakcheck | default 3472 bytes leaked (APZEventState, ActiveElementManager, IAPZCTreeManager, IMContextWrapper, InputQueue, ...)
  TEST-UNEXPECTED-FAIL | leakcheck | tab 2176 bytes leaked (DrawTargetSkia, MozPromiseRefcountable, Mutex, PuppetWidget, StringBuffer, ...)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5baeea7c14f6
Refactor user characteristics code. r=timhuang

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing multiple failures.

• Backout link

---

• Push with failures - build bustages
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/gfx/gl/GLContextProviderWGL.cpp(475,8): error: no viable conversion from 'mozilla::CastableTypedEnumResult<CreateContextFlags>' to 'bool'

---

• Push with failures - leak failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | leakcheck | tab 232 bytes leaked (Mutex, StringBuffer, nsJSPrincipals, nsSimpleURI)

---

• Push with failures - reftests failures
• Failure Log
• Failure line: Assertion failure: NS_IsMainThread(), at /builds/worker/checkouts/gecko/dom/base/nsContentUtils.cpp:3616

Comment 6

[Fatih Kilic [:fkilic]]

Working on a fix right now, thank you!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/345e2bfe0f5e
Refactor user characteristics code. r=timhuang

Comment 8

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_usercharacteristics.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/resistfingerprinting/tests/browser/browser_usercharacteristics.js | Test timed out -

Comment 9

[Fatih Kilic [:fkilic]]

I have no idea why the timeout would happen since we didn't get them on try branch. I'll take a look into it. Thank you!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/976d1edb7d13
Refactor user characteristics code. r=timhuang

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/976d1edb7d13