1901796 - Crash in [@ kotlin.UninitializedPropertyAccessException: at org.mozilla.fenix.settings.logins.fragment.SavedLoginsFragment$onViewCreated$2.invoke(SavedLoginsFragment.kt)]

Status: RESOLVED FIXED

(Firefox for Android :: Logins, defect, P3)

Description

[Chris Peterson [:cpeterson]]

Crash report: https://crash-stats.mozilla.org/report/index/c1ef8e52-eef8-4559-98a3-2e3ae0240611

Exception: kotlin.UninitializedPropertyAccessException
Message: lateinit property sortingStrategyMenu has not been initialized

Top 10 frames:

0  org.mozilla.fenix.settings.logins.fragment.SavedLoginsFragment$onViewCreated$2  invoke  SavedLoginsFragment.kt:224
1  mozilla.components.lib.state.ext.FragmentKt$consumeFrom$1  invokeSuspend  Fragment.kt:88
2  kotlin.coroutines.jvm.internal.BaseContinuationImpl  resumeWith  ContinuationImpl.kt:9
3  kotlinx.coroutines.DispatchedTask  run  DispatchedTask.kt:111
4  android.os.Handler  handleCallback  Handler.java:900
5  android.os.Handler  dispatchMessage  Handler.java:103
6  android.os.Looper  loop  Looper.java:219
7  android.app.ActivityThread  main  ActivityThread.java:8393
8  java.lang.reflect.Method  invoke  Method.java:-2
9  com.android.internal.os.RuntimeInit$MethodAndArgsCaller  run  RuntimeInit.java:513

Comment 1

[Alexandra Virvara]

Attachment: WIP: Bug 1901796: App crashes when trying to update the sorting strategy menu and it hasn't been initialized yet

Comment 2

[Alexandra Virvara]

Attachment: Bug 1901796: Make sure that the sorting strategy menu is initialised before using it

Comment 3

[BugBot [:suhaib / :marco]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 AArch64 and ARM crashes on release

For more information, please visit BugBot documentation.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Looking at the discussion in the attached patch and the related one, I'm wondering if the patches in development are going to be suitable for uplift to 128? We would like to address this crash spike there as well. Is there a lower-risk fix we could take to address the crash?

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Thank you for the ping Ryan!
Checked with Alexandra and we can go with a simple patch that would avoid the crash now.
While we can continue with more foundational work after.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f0c1c321f76
Make sure that the sorting strategy menu is initialised before using it r=android-reviewers,petru

Comment 7

[Alexandra Virvara]

Comment on attachment 9408643 [details]
Bug 1901796: Make sure that the sorting strategy menu is initialised before using it

Beta/Release Uplift Approval Request

• User impact if declined: app crashes sometimes when trying to access the SavedLogins screen
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): this is a small change that does not have other side effects
• String changes made/needed:
• Is Android affected?: Yes

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9408643 [details]
Bug 1901796: Make sure that the sorting strategy menu is initialised before using it

Switching uplift request from beta to release. Fx128 is now in release.
This will ride the train to beta with Fx129.

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5f0c1c321f76

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9408643 [details]
Bug 1901796: Make sure that the sorting strategy menu is initialised before using it

Approved for Fenix/Focus 128.0.1.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/456e8553efb7