1901821 - Add an option to display a divider before the IconButton in FaviconListItem and IconListItem

Status: RESOLVED FIXED

(Fenix :: Design System and Theming, task, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Screenshot

In the menu redesign, we have a favicon and icon list item that can have a vertical divider line before the IconButton. The task here is to provide an option to show this vertical line before the IconButton in the after list action for FaviconListItem and IconListItem which would be used in the extensions submenu.

Figma: https://www.figma.com/design/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?node-id=9730-4989&m=dev

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1901821 - Part 1: Reorder the url parameter in FaviconListItem

• Reorder the parameters so that the required parameters appear before the optional parameters to follow
  https://android.googlesource.com/platform/frameworks/support/+/androidx-main/compose/docs/compose-component-api-guidelines.md#parameters-order

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1901821 - Part 2: Remove text button as an after list action use case in IconListItem

• The menu redesign removed the use case where we needed a text button as an after list action for IconListItem.
  As a result, we should remove this for the time being.
• Reverts https://bugzilla.mozilla.org/show_bug.cgi?id=1891341

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1901821 - Part 3: Add an option to display a divider before the IconButton in FaviconListItem and IconListItem

• Provides an option in FaviconListItem and IconListItem to display a vertical divider line before the IconButton.
• Implements AddonMenuItem that will be used in the extensions submenu

Figma: https://www.figma.com/design/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?node-id=9730-4989&m=dev

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f77c4477b01
Part 1: Reorder the url parameter in FaviconListItem r=android-reviewers,007
https://hg.mozilla.org/integration/autoland/rev/364fc144d138
Part 2: Remove text button as an after list action use case in IconListItem r=android-reviewers,007

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2f77c4477b01
https://hg.mozilla.org/mozilla-central/rev/364fc144d138

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d6f4f3f7eb3
Part 3: Add an option to display a divider before the IconButton in FaviconListItem and IconListItem r=android-reviewers,007

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/0d6f4f3f7eb3