1901834 - Build with pixman < 0.40.0 fails with `error: unknown type name 'pixman_dither_t'`

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Paul Menzel]

Steps to reproduce:

Build Firefox 127.0 on GNU/Linux with pixman 0.38.4 installed.

Actual results:

The build fails with:

[…]
15:25.42 In file included from Unified_c_gfx_cairo_cairo_src2.c:20: 
15:25.43 /dev/shm/bee-pmenzel/firefox/firefox-127.0-0/source/gfx/cairo/cairo/src/cairo-image-surface.c:954:5: error: unknown type name 'pixman_dither_t'; did you mean 'pixman_f
ilter_t'?
15:25.44     pixman_dither_t pixman_dither = _cairo_dither_to_pixman_dither (source->dither);
15:25.44     ^~~~~~~~~~~~~~~
15:25.44     pixman_filter_t
15:25.44 /usr/include/pixman-1/pixman.h:317:3: note: 'pixman_filter_t' declared here
15:25.44 } pixman_filter_t;
15:25.44   ^
15:25.44 In file included from Unified_c_gfx_cairo_cairo_src2.c:20: 
15:25.45 /dev/shm/bee-pmenzel/firefox/firefox-127.0-0/source/gfx/cairo/cairo/src/cairo-image-surface.c:954:37: error: implicit declaration of function '_cairo_dither_to_pixman_
dither' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
15:25.45     pixman_dither_t pixman_dither = _cairo_dither_to_pixman_dither (source->dither);
15:25.45                                     ^
15:25.45 /dev/shm/bee-pmenzel/firefox/firefox-127.0-0/source/gfx/cairo/cairo/src/cairo-image-surface.c:955:5: error: implicit declaration of function 'pixman_image_set_dither' 
is invalid in C99 [-Werror,-Wimplicit-function-declaration]
15:25.45     pixman_image_set_dither (surface->pixman_image, pixman_dither);
15:25.46     ^
15:25.46 /dev/shm/bee-pmenzel/firefox/firefox-127.0-0/source/gfx/cairo/cairo/src/cairo-image-surface.c:955:5: note: did you mean 'pixman_image_set_filter'?
15:25.46 /usr/include/pixman-1/pixman.h:829:17: note: 'pixman_image_set_filter' declared here
15:25.46 pixman_bool_t   pixman_image_set_filter              (pixman_image_t               *image,
15:25.46                 ^
15:26.77 image/encoders/bmp
15:27.13 3 errors generated.
15:27.13 make[4]: *** [/dev/shm/bee-pmenzel/firefox/firefox-127.0-0/source/config/rules.mk:600: Unified_c_gfx_cairo_cairo_src2.o] Error 1
15:27.14 make[4]: *** Waiting for unfinished jobs....
15:27.16 image/encoders/ico
15:28.07 image/encoders/jpeg
15:32.08 image/encoders/png
15:37.63 image/encoders/webp
15:41.07 make[3]: *** [/dev/shm/bee-pmenzel/firefox/firefox-127.0-0/source/config/recurse.mk:72: gfx/cairo/cairo/src/target-objects] Error 2
15:41.07 make[3]: *** Waiting for unfinished jobs....

Expected results:

The build should succeed or configure check, that required pixman version is installed.

Quickly looking through pixman, commit ddcc41b99956 (Implement basic dithering for the wide pipeline, v3), present since version 0.40.0 seems to have added it.

Comment 1

[Paul Menzel]

The configure script output is:

 0:18.51 checking for pixman-1 >= 0.36.0... yes
 0:18.51 checking MOZ_PIXMAN_CFLAGS... -I/usr/include/pixman-1
 0:18.51 checking MOZ_PIXMAN_LIBS... -lpixman-1

which should be updated.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1901834 - Update pixman version requirement. r=#gfx-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/746a29573d39
Update pixman version requirement. r=gfx-reviewers,aosmond

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1892913

Comment 6

[Paul Menzel]

Thank you for the patch. I’d be more specific in the commit message title: Update pixman version requirement from 0.36. to 0.40.0.

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/746a29573d39

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jfkthame, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox128 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Jonathan Kew [:jfkthame]]

This only affects people building with a system-installed pixman, rather than our in-tree version, but for their benefit I think it'd be worth uplifting (we should have done this as part of landing the cairo update).

Comment 10

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1901834 - Update pixman version requirement.

Original Revision: https://phabricator.services.mozilla.com/D213442

Comment 11

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: possible build failure with --enable-system-pixman
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: minimal
• Explanation of risk level: just updating a configure check
• String changes made/needed: none
• Is Android affected?: no

Comment 12

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1901834 - Update pixman version requirement.

Original Revision: https://phabricator.services.mozilla.com/D213442

Comment 13

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: possible build failure using --enable-system-pixman
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: minimal
• Explanation of risk level: just update configure check
• String changes made/needed: none
• Is Android affected?: no

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/88e1c016e4d3

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/0cdd98e1db10