1901839 - Classify engagements for requests that match an ad but didn't have a corresponding component as `ad_uncategorized` instead of `non_ads_link`

Status: RESOLVED FIXED

(Firefox :: Search, task, P1)

Description

[James Teow [:jteow]]

Currently, when we observe a URL in the network process, we categorize an engagement with no matching ad_impression component type as non_ads_link.

One issue is if ads are loaded after ad_impressions are recorded, such as from infinite scrolling, we categorize the engagement as non_ads_link while Legacy telemetry by way of using regular expressions on the URL would consider it an ad click.

To help reach parity between Legacy Telemetry and Glean Telemetry, we should still consider the click an ad.

The component name should be something descriptive to indicate we weren't able to categorize it. I propose we use ad_uncategorized.

Comment 1

[James Teow [:jteow]]

Attachment: WIP: - Bug 1901839 - Classify engagements from urls that aren't categorized but match ads as ad_uncategorized - r?standard8!

Comment 2

[James Teow [:jteow]]

Attachment: WIP: - Bug 1901839 - Classify engagements from urls that aren't categorized but match ads as ad_uncategorized - r?standard8!

Comment 3

[James Teow [:jteow]]

Attachment: Bug 1901839 - Classify engagements from urls that aren't categorized but match ads as ad_uncategorized - r?standard8!

Comment 4

[James Teow [:jteow]]

Attachment: Bug 1901839 - Classify engagements from urls that aren't categorized but match ads as ad_uncategorized - r?standard8!

Comment 5

[James Teow [:jteow]]

The reason why there are so many attachments is because locally, the messages I received were that the Phabricator submissions failed.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b82491dbbcca
Classify engagements from urls that aren't categorized but match ads as ad_uncategorized - r=Standard8

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b82491dbbcca