Closed Bug 1901855 Opened 1 year ago Closed 1 year ago

Add a probe to count how often we hit socket limits

Categories

(Core :: Networking: HTTP, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
130 Branch
Tracking Status
firefox130 --- fixed

People

(Reporter: acreskey, Assigned: acreskey)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(2 files)

In bug 1889771 we are looking to increase the size of the socket pool on android.
It would be useful to have telemetry to know how often we hit this limit
(We used to have this in bug 1260218, but not on Android)

Assignee: nobody → acreskey
Severity: -- → N/A
Priority: -- → P2
Whiteboard: [necko-triaged]
See Also: → 1889771
Summary: Add a probe to count how often we hit the max http connection limit → Add a probe to count how often we hit our internal max socket limit
Summary: Add a probe to count how often we hit our internal max socket limit → Add a probe to count how often we hit our internal socket limit
Summary: Add a probe to count how often we hit our internal socket limit → Add a probe to count how often we hit socket limits, internal and OS
Blocks: 1903115

Changing scope back to tracking of OS socket limits.

Summary: Add a probe to count how often we hit socket limits, internal and OS → Add a probe to count how often we hit socket limits

We are looking at increasing the limit on Android and telemetry would be useful.

Please review attached data review request.

Attachment #9410242 - Flags: data-review?(chutten)

Comment on attachment 9410242 [details]
socket_limit_data_review.md

Actually, there's a new Data Review process in town. Starting May 7, all data collections in projects reviewed in Phabricator also perform data review in Phabricator: https://wiki.mozilla.org/Data_Collection#Firefox_Desktop.2C_Firefox_and_Focus_for_Android.2C_Gecko_.28from_May_7.2C_2024.29

In short, following what the Herald message says, code authors and code reviewers together determine what level of review is needed for new or expanded data collections. You might never need to fill out a data review request form again! (For instrumentation in projects reviewed in Phabricator, anyway)

Attachment #9410242 - Flags: data-review?(chutten)

(In reply to Chris H-C :chutten from comment #4)

Comment on attachment 9410242 [details]
socket_limit_data_review.md

Actually, there's a new Data Review process in town. Starting May 7, all data collections in projects reviewed in Phabricator also perform data review in Phabricator: https://wiki.mozilla.org/Data_Collection#Firefox_Desktop.2C_Firefox_and_Focus_for_Android.2C_Gecko_.28from_May_7.2C_2024.29

In short, following what the Herald message says, code authors and code reviewers together determine what level of review is needed for new or expanded data collections. You might never need to fill out a data review request form again! (For instrumentation in projects reviewed in Phabricator, anyway)

Ah, I thought the Phabricator tags were in an addition to the existing process.
Thank you!

Pushed by acreskey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0c477faaf755 Add a probe to count how often we hit our internal socket limit r=necko-reviewers,kershaw
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: