[wpt-sync] Sync PR 46707 - [FedCM] Show account chooser for non-returning user on approved client
Categories
(Core :: DOM: Credential Management, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox129 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 46707 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/46707
Details from upstream follow.
Zachary Tan <tanzachary@chromium.org> wrote:
[FedCM] Show account chooser for non-returning user on approved client
Currently on button mode, for this particular case of a logged out
user signing in as a non-returning user on an RP which is in the list
of approved clients, we would show disclosure UI without the
disclosure text. This patch makes it such that we show the account
chooser instead because the disclosure UI without the disclosure text
is unnecessary new UI surface which doesn't convey any additional
information compared to the account chooser.Note that we show the multi account picker instead of the single account
picker. This is because when we were showing disclosure UI, the user was
able to go back and retrieve the original list of accounts by clicking
the "Back" button. However, the "back" button is not available on the
account pickers. We prefer a multi account picker compared to having an
additional UI surface. The most recently signed in accounts are shown
at the top of the multi account picker.This patch also refactors the state machine. We used to set the state_
to State::REQUEST_PERMISSION for single account pickers on the bubble
but that is confusing. This patch changes it to have state_ be
State::SINGLE_ACCOUNT_PICKER.Bug: 342557704
Change-Id: I9435ee5a34cf47567c6a4a16bbffd99ba8eee798
Reviewed-on: https://chromium-review.googlesource.com/5578254
WPT-Export-Revision: 68b607102df63f64324795072a59a0dba33f8c26
|
Assignee | |
Updated•16 days ago
|
|
|
Assignee | |
Comment 1•16 days ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5aa8bd64fdc6f42524589c6d2129d487648ecaf9
|
|
Assignee | |
Comment 2•16 days ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 2 tests and 1 subtests
Status Summary
Firefox
TIMEOUT: 4
NOTRUN : 1
Chrome
OK : 1
FAIL : 2
TIMEOUT: 1
ERROR : 1
Safari
TIMEOUT: 2
ERROR : 2
NOTRUN : 1
Links
Details
New Tests That Don't Pass
- /credential-management/fedcm-button-and-other-account/fedcm-use-other-account-button-flow.tentative.https.html [wpt.fyi]:
TIMEOUT(Chrome:ERROR, Safari:ERROR)- Test that the "Use Other Account" button works correctly.:
TIMEOUT(Chrome:FAIL, Safari:TIMEOUT) - Test that the "Use Other Account" button works correctly when accounts do not change.:
NOTRUN(Chrome:TIMEOUT, Safari:NOTRUN)
- Test that the "Use Other Account" button works correctly.:
- /credential-management/fedcm-button-and-other-account/fedcm-use-other-account.tentative.https.html [wpt.fyi]:
TIMEOUT(Chrome:OK, Safari:ERROR)- Test that the "Use Other Account" button works correctly.:
TIMEOUT(Chrome:FAIL, Safari:TIMEOUT)
- Test that the "Use Other Account" button works correctly.:
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7612abc3b8c9 [wpt PR 46707] - [FedCM] Show account chooser for non-returning user on approved client, a=testonly
|
||
Comment 4•13 days ago
|
||
| bugherder | ||
Description
•