Move default browser prompt check into Messaging System
Categories
(Firefox :: Messaging System, enhancement, P1)
Tracking
()
People
(Reporter: mviar, Assigned: hanna_a)
References
(Blocks 1 open bug)
Details
The default browser prompt launched from BrowserGlue has conflicted with messages in Messaging System. We should consider moving this message into Messaging System to help avoid future collisions, give this prompt a look more consistent with other in-browser messages, and allow for greater control of users' overall message journeys.
Reporter | ||
Updated•8 months ago
|
Comment 1•8 months ago
|
||
Let's see if we can get design guidance on how this message should look once we've moved it to messaging system. Which surface can perform better than this? Possibly infobar. Possibly feature callout without a notch, but that wouldn't be modal. Spotlight would be modal, but Spotlight has very different styles. Ideally we can get an updated design for this.
We should also tag Gijs for review since I think he is closest to "owning" this message?
Reporter | ||
Updated•4 months ago
|
Reporter | ||
Comment 2•4 months ago
|
||
We'll start work on this in 133 Nightly. As noted above, we'll want input from design, but will probably use a Spotlight modal with some style updates. We can discuss whether to replicate the current dialog's appearance or update the design.
As for triggering the new prompt message, we could potentially refactor DefaultBrowserCheck.prompt to use sendTriggerMessage
. These conditionals in prompt
determine which strings/actions should be shown. We could have message configurations for all possible combinations of strings and prompts with the appropriate screen targeting, similar to how we choose which actions to show on the first card of about:welcome.
We would also need to add a special message action corresponding to setting shellService.shouldCheckDefaultBrowser = false
here.
I imagine will also want preserve the existing BROWSER_SET_DEFAULT_RESULT
telemetry, but it would be worth reaching out to to see if/how that telemetry is currently being used and whether it could be replaced with existing click telemetry available in Spotlight.
Reporter | ||
Updated•4 months ago
|
Description
•