1902063 - Wallpaper attribution text hangs awkwardly in the middle when shortcuts are disabled

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P3)

Description

[Patrycja Rosa [:ptrcnull] (she/her)]

Attachment: Screenshot of the new tab, with an aurora borealis wallpaper and the text "Photo by Lightscape on Unsplash" in the middle of the screen

as in the title/screenshot; to be fair, i'm not sure if it's intended behaviour, but it simply looks awkward

Comment 1

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Could you please provide any information that might help us reproduce this bug, such as steps to reproduce, OS used, and/or any other configuration needed?
Thank you.

Comment 2

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Managed to reproduce this issue on Firefox Nightly 129.0a1 on:

• Windows 10;
• macOS 14;
• Ubuntu 22;

STR used:

1. Launch Firefox.
2. Navigate to about:newtab and open the gear wheel in the top-right corner.
3. Select any wallpaper.
4. Disable Shortcuts, Recommended stories and Recent activity sections.

Setting as NEW.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:amy, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[Maxx Crawford [:maxx]]

Attachment: Bug 1902063 - Fix issue where wallpaper attribution was mispositioned if only one section/element was active on HNT page r?#home-newtab-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a109e447e57e
Fix issue where wallpaper attribution was mispositioned if only one section/element was active on HNT page r=home-newtab-reviewers,thecount

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a109e447e57e

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:maxx, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox129 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Patrycja Rosa [:ptrcnull] (she/her)]

it seems like the new CSS rules only apply to @media (min-width: 866px), resizing the window makes the text rapidly jump up to the middle of the screen again

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible using the latest Firefox Nightly 131.0a1 (Build ID: 20240821160637) and the latest Firefox Beta 130.0b8 (Build ID: 20240821091813) installed on Windows 10 x64, macOS 14.5, and Ubuntu 22.04 x64. I can confirm that the "Photo by Lightscape on Unsplash" title is displayed in the bottom left part of the page.