1902214 - Clean up old cruft from clang-plugin build setup

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1902214 - Don't filter-out /path/to/clang/lib from LDFLAGS on mac.

We did that to avoid linking against clang's libc++, but that hasn't
been necessary since we removed it in bug 1788870.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1902214 - Stop filtering out -isysroot and -gcc-toolchain.

-isysroot was appearing in the llvm-config output on mac in very old
clang.llvm.org builds. The latest builds don't do that anymore, and our
own bootstrapped builds don't either.

-gcc-toolchain was filtered out because we were using it to build our
own clang and that transpired in llvm-config, but we don't anymore, as
of bug 1719226.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1902214 - Move -flat_namespace and -undefined suppress flags out of configure.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1902214 - Move clang library linkage to moz.build.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1902214 - Use -std:c++17 on clang-cl builds.

For some reason, we ended up using -Xclang -std=c++17, when we could
just have used -std:c++17, which simplifies things.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1902214 - Don't try to convert arguments from /ARG form to -ARG form.

Back when this was done, we had some trouble with make calling commands
through the shell instead of via CreateProcess on Windows, which made
the intermediate shell replace /ARG with c:\path\to\msys\ARG paths,
which didn't end up well.

This however doesn't happen anymore, so we can get rid of the hack.

That leaves us with only the backslash problem, but because it's a windows
problem, rather than being related to the compiler being clang-cl, we also
fix the condition under which we make the switch to forward slashes.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eca3b11bb9a3
Don't filter-out /path/to/clang/lib from LDFLAGS on mac. r=firefox-build-system-reviewers,sergesanspaille
https://hg.mozilla.org/integration/autoland/rev/458f017c01a5
Stop filtering out -isysroot and -gcc-toolchain. r=firefox-build-system-reviewers,sergesanspaille
https://hg.mozilla.org/integration/autoland/rev/39785c41d70c
Move -flat_namespace and -undefined suppress flags out of configure. r=firefox-build-system-reviewers,sergesanspaille
https://hg.mozilla.org/integration/autoland/rev/164f41e926db
Move clang library linkage to moz.build. r=firefox-build-system-reviewers,sergesanspaille
https://hg.mozilla.org/integration/autoland/rev/51a17c834d88
Use -std:c++17 on clang-cl builds. r=firefox-build-system-reviewers,sergesanspaille
https://hg.mozilla.org/integration/autoland/rev/60ccda7205ff
Don't try to convert arguments from /ARG form to -ARG form. r=firefox-build-system-reviewers,sergesanspaille

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/eca3b11bb9a3
https://hg.mozilla.org/mozilla-central/rev/458f017c01a5
https://hg.mozilla.org/mozilla-central/rev/39785c41d70c
https://hg.mozilla.org/mozilla-central/rev/164f41e926db
https://hg.mozilla.org/mozilla-central/rev/51a17c834d88
https://hg.mozilla.org/mozilla-central/rev/60ccda7205ff