1902264 - The PromptListener wrongly selects prompts on Android when receiving a `geckoview-prompt-show` notification

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Just noticed this problem when trying to add support for the beforeunload prompt type in WebDriver BiDi. There are two issues:

1. The subject argument is a wrapped value and as such requires us to use .wrappedJSObject. Otherwise the retrieved prompt id is undefined.

2. When iterating through the open windows we find prompts but using item.id is as well undefined. Comparing it with the prompt id that we are looking for is equal and as such results in a found prompt, which is not necessarily the one that we need.

Given that this is Android we may want to have a look at this bug in the next milestone?

Comment 1

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1902264 - Add a method to get a prompt id to GeckoView.

Comment 2

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1902264 - Check correctly for prompt id when receiving a "geckoview-prompt-show" on Android.

Comment 3

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1902264 - [wdspec] Add test for "browsingContext.userPromptOpened" event with two prompts.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15f652637235
Add a method to get a prompt id to GeckoView. r=geckoview-reviewers,owlish
https://hg.mozilla.org/integration/autoland/rev/4ecda0d095a8
Check correctly for prompt id when receiving a "geckoview-prompt-show" on Android. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/f13eef0bb6c6
[wdspec] Add test for "browsingContext.userPromptOpened" event with two prompts. r=webdriver-reviewers,jdescottes

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/47070 for changes under testing/web-platform/tests

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/15f652637235
https://hg.mozilla.org/mozilla-central/rev/4ecda0d095a8
https://hg.mozilla.org/mozilla-central/rev/f13eef0bb6c6

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot