1902288 - Add 16 KB Page Size support to Android

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Mihai Adrian Carare [:mcarare]]

See https://developer.android.com/about/versions/15/behavior-changes-all#16-kb.

As we use native code, our app will be impacted.

Supporting 16 KB memory page sizes will also bring performance improvement.

Starting next year Google plans to make 16 KB page compatibility required for app uploads to the Google Play store. ( No definitive date mentioned, as usual).

We should check if we already have support and what we need do add it if not.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

See also: https://android-developers.googleblog.com/2024/08/adding-16-kb-page-size-to-android.html

Serge, are there changes we need to make in the build system to support this? I'm thinking this is more of a GeckoView question than Fenix since that's where the native code lives.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

This might also impact Application Services and Glean IIUC.

Comment 3

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Fenix::Performance' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[[:sergesanspaille]]

According to https://developer.android.com/guide/practices/page-sizes#build one needs to pass the extra "-Wl,-z,max-page-size=16384" linker flag if NDK version is <= 26 and we seem to support 21+. If you go that way, please create a bug and assign it to me, I can deal with it.

I cannot tell for the gradle part.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

AFAICT, we need to add "-Wl,-z,max-page-size=16384" to wherever we set our Android ldflags. My understanding is that we don't use the llvm toolchain from the NDK in favor of our own builds and therefore can't rely on whatever the NDK does.

Comment 6

[[:sergesanspaille]]

Attachment: Bug 1902288 - Add 16 KB Page Size support to Android r=glandium

Comment 7

[[:sergesanspaille]]

patch submitted, feel free to comment there

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea5154572139
Add 16 KB Page Size support to Android r=glandium

Comment 9

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/ea5154572139