1902319 - Separate BTP user interaction tracking from ContentBlockingUserInteraction

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P2)

Description

[Paul Zühlcke [:pbz]]

We have RecordUserActivationForBTP on PWindowGlobal now so it should be relatively easy to add our own call coming from the Document on user activation.
Separating the messages makes the code more maintainable and easier to read. It also allows us to solve a shortcoming of the existing user interaction code which doesn't correctly record user activation for the top level if the user interacts with the iframe.
The spec describes this attribution to the top level site host in the algorithm here: https://privacycg.github.io/nav-tracking-mitigations/#bounce-tracking-mitigations-activation-monkey-patch

Comment 1

[Paul Zühlcke [:pbz]]

Attachment: Bug 1902319 - Separate BTP user interaction tracking from ContentBlockingUserInteraction and record user interaction for iframes. r=#anti-tracking!

Comment 2

[Paul Zühlcke [:pbz]]

Attachment: Bug 1902319 - Add tests for updated BTP user activation tracking. r=#anti-tracking!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/530b43559b31
Separate BTP user interaction tracking from ContentBlockingUserInteraction and record user interaction for iframes. r=anti-tracking-reviewers,manuel
https://hg.mozilla.org/integration/autoland/rev/b2f40abb0309
Add tests for updated BTP user activation tracking. r=anti-tracking-reviewers,manuel

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing bustages on BounceTrackingProtection.h

Backout link

Push with failures

Failure log

Comment 5

[Paul Zühlcke [:pbz]]

Thanks! That's a non-unified build failure. I think BounceTrackingProtection.h is missing a forward declaration of WindowContext. Should be easy to fix.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0c1a4858111
Separate BTP user interaction tracking from ContentBlockingUserInteraction and record user interaction for iframes. r=anti-tracking-reviewers,manuel
https://hg.mozilla.org/integration/autoland/rev/38f8fb84e7c2
Add tests for updated BTP user activation tracking. r=anti-tracking-reviewers,manuel

Comment 7

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/c0c1a4858111
https://hg.mozilla.org/mozilla-central/rev/38f8fb84e7c2