Closed Bug 1902353 Opened 9 months ago Closed 8 months ago

Investigate consolidating the Tabs Tray Store observation calls

Categories

(Fenix :: Tabs, task, P3)

All
Android
task

Tracking

(firefox130 fixed)

RESOLVED FIXED
130 Branch
Tracking Status
firefox130 --- fixed

People

(Reporter: 007, Assigned: 007)

References

Details

(Whiteboard: [fxdroid][group4])

Attachments

(1 file)

After the AppStore and BrowserStore dependencies are removed from the composified Tabs Tray, we should investigate a better way to handle the single store observations.

Notably whether:

  • The calls can be collapsed to one observation, and the state is passed down.
  • The tab page composables can have their calls removed and simply have their depedent data added to their API and fed-in via the root Composable.
Depends on: 1899890

Rather than have numerous TabsTrayStore observations in leaf nodes, we now perform one observation at the root node and pass-down all of the individual dependencies to where they are needed.

This should help cut down on the amount of Store listeners that are active while the Tabs Tray is open and move us one step closer to following a unidirectional data flow in this feature.

Status: NEW → ASSIGNED
Pushed by nbond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ee20d7161871 Consolidate the TabsTrayStore calls into one at the root level r=android-reviewers,matt-tighe
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: