Closed Bug 1902365 Opened 5 months ago Closed 5 months ago

Replace VideoFrame::SampleCount by ::ByteCount

Categories

(Core :: Audio/Video: Web Codecs, task, P1)

task

Tracking

()

RESOLVED FIXED
129 Branch
Tracking Status
firefox129 --- fixed

People

(Reporter: chunmin, Assigned: chunmin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The SampleCount is used to compare with the byte size of the given buffer, so the name is misleading. In addition, we should use another way to calculate the byte size instead of relying on the formats directly, so it's easier to maintain when new formats are introduced.

Attachment #9407315 - Attachment description: Bug 1902365 - Replace SampleCount by ByteCount → Bug 1902365 - Rename SampleCount to ByteCount for accurate byte calculation
Attachment #9407315 - Attachment description: Bug 1902365 - Rename SampleCount to ByteCount for accurate byte calculation → Bug 1902365 - Rework and rename SampleCount to ByteCount for accurate byte calculation
Pushed by cchang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/63d290336a3a Rework and rename SampleCount to ByteCount for accurate byte calculation r=media-playback-reviewers,padenot
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: