Closed Bug 1902373 Opened 1 year ago Closed 1 year ago

Create a compose-base component to upstream base compose components

Categories

(Firefox for Android :: Design System and Theming, task, P3)

Product:
Firefox for Android
Component:
Design System and Theming
Platform:
All
Android
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
135 Branch
Tracking Flags:
Tracking Status
firefox135 --- fixed

People

(Reporter: gl, Assigned: gl)

References

(Blocks 2 open bugs)

Details

Attachments

(12 files, 13 obsolete files)

Bug 1902373 - Part 1: Rename FirefoxTheme and FirefoxColors to use Acorn prefix
48 bytes, text/x-phabricator-request
Details | Review
Bug 1902373 - Part 2: Add a FirefoxTheme wrapper around AcornTheme
48 bytes, text/x-phabricator-request
Details | Review
Bug 1902373 - Part 3: Refactor FenixTypography to AcornTypography
48 bytes, text/x-phabricator-request
Details | Review
Bug 1902373 - Part 4: Add an initial AC compose-base component
48 bytes, text/x-phabricator-request
Details | Review
Bug 1902373 - Part 5: Refactor LightDarkPreview annotation into compose-base
48 bytes, text/x-phabricator-request
Details | Review
Bug 1902373 - Part 6: Use the LightDarkPreview annotation from compose-base in feature-prompts
48 bytes, text/x-phabricator-request
Details | Review
Bug 1902373 - Part 7: Refactor inComposePreview utils to compose-base
48 bytes, text/x-phabricator-request
Details | Review
Bug 1902373 - Part 8: Refactor AcornTheme, AcornTypography and AcornLayout into compose-base
48 bytes, text/x-phabricator-request
Details | Review
Bug 1902373 - Part 9: Refactor FlexibleWindowLightDarkPreview and FlexibleWindowPreview annotations into compose-base
48 bytes, text/x-phabricator-request
Details | Review
Bug 1902373 - Part 10: Refactor Divider into compose-base
48 bytes, text/x-phabricator-request
Details | Review
Bug 1902373 - Part 11: Refactor TextButton to compose-base
48 bytes, text/x-phabricator-request
Details | Review
Bug 1902373 - Part 12: Add compose-base to taskcluster config
48 bytes, text/x-phabricator-request
Details | Review

The task is to create a new compose-base component that will serve as a component that will only contain base composable components that are based on Acorn Design System.

The motivation here is to initially uplift 1-2 components and ensure we have an initial foundation to iterate and build upon.

In order to make AcornTheme independent, we need to remove the dependency on LocalContext.current.settings().lastKnownMode.isPrivate, which means we will need to supply this as a parameter.

  • Setups a boilerplate AC component that will serve as a component containing base Composable components based on the Acorn Design System.
Attachment #9407346 - Attachment description: Bug 1902373 - Part 11: Add compose-base to taskcluster config → Bug 1902373 - Part 11: Add compose-base to taskcluster config
Attachment #9407336 - Attachment is obsolete: true
Attachment #9407337 - Attachment is obsolete: true
Attachment #9407338 - Attachment is obsolete: true
Attachment #9407339 - Attachment is obsolete: true
Attachment #9407340 - Attachment is obsolete: true
Attachment #9407341 - Attachment is obsolete: true
Attachment #9407342 - Attachment is obsolete: true
Attachment #9407343 - Attachment is obsolete: true
Attachment #9407344 - Attachment is obsolete: true
Attachment #9407345 - Attachment is obsolete: true
Attachment #9407346 - Attachment is obsolete: true
  • Adds a FirefoxTheme wrapper to provide access to the Acorn theme tokens.
  • Move handling of the local theming from AcornTheme to FirefoxTheme.
  • Adds a FirefoxTheme wrapper to provide access to the Acorn theme tokens.
  • Move handling of the local theming from AcornTheme to FirefoxTheme.
  • Setups a boilerplate AC component that will serve as a component containing base Composable components based on the Acorn Design System.
  • Optimize imports was ran on the Fenix project. This will include some import optimizations.
Attachment #9421339 - Attachment is obsolete: true
Attachment #9421340 - Attachment is obsolete: true
Attachment #9421353 - Attachment description: Bug 1902373 - Part 8: Refactor AcornTheme, AcornTypography and AcornLayo into compose-base → Bug 1902373 - Part 8: Refactor AcornTheme, AcornTypography and AcornLayout into compose-base
Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d0d12ad2dd4e Part 1: Rename FirefoxTheme and FirefoxColors to use Acorn prefix r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/76d8d61a765a Part 2: Add a FirefoxTheme wrapper around AcornTheme r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/760f8afe62b9 Part 3: Refactor FenixTypography to AcornTypography r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/1785104753e3 Part 4: Add an initial AC compose-base component r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/e04155caa4f0 Part 5: Refactor LightDarkPreview annotation into compose-base r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/2caef11a2256 Part 6: Use the LightDarkPreview annotation from compose-base in feature-prompts r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/db82520b5de3 Part 7: Refactor inComposePreview utils to compose-base r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/90fffe183f3d Part 8: Refactor AcornTheme, AcornTypography and AcornLayout into compose-base r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/8fae4bd4e44c Part 9: Refactor FlexibleWindowLightDarkPreview and FlexibleWindowPreview annotations into compose-base r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/bf4ec0320112 Part 10: Refactor Divider into compose-base r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/232d7356c69f Part 11: Refactor TextButton to compose-base r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/498fb5e259cc Part 12: Add compose-base to taskcluster config r=aryx,Roger
Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eb80827a2b0f Part 1: Rename FirefoxTheme and FirefoxColors to use Acorn prefix r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/820eac7ed1c9 Part 2: Add a FirefoxTheme wrapper around AcornTheme r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/7d743d09cd26 Part 3: Refactor FenixTypography to AcornTypography r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/91ae8175bfb7 Part 4: Add an initial AC compose-base component r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/95f6d4a2801f Part 5: Refactor LightDarkPreview annotation into compose-base r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/b3f64b4d42c7 Part 6: Use the LightDarkPreview annotation from compose-base in feature-prompts r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/53e604c8792e Part 7: Refactor inComposePreview utils to compose-base r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/6fa570c0910b Part 8: Refactor AcornTheme, AcornTypography and AcornLayout into compose-base r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/75912798bfd7 Part 9: Refactor FlexibleWindowLightDarkPreview and FlexibleWindowPreview annotations into compose-base r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/1536cb578503 Part 10: Refactor Divider into compose-base r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/bfb02c430aff Part 11: Refactor TextButton to compose-base r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/36e58529c82c Part 12: Add compose-base to taskcluster config r=aryx,Roger
Pushed by smolnar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bf345b08c89c Fix ktlint failure. a=lint-fix CLOSED TREE
Flags: needinfo?(gl)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: