1902649 - Update PDF.js to new version e3caa3c6eeda90099dd03b451b6b4788746455b3 from 2024-06-14 08:48:18

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, enhancement)

Description

[Update Bot]

This update covers 10 commits. Here are the overall diff statistics, and then the commit information.

---

taskcluster/kinds/fetch/toolchains.yml | 2 +-
toolkit/components/pdfjs/content/PdfJsDefaultPreferences.sys.mjs | 1 +
toolkit/components/pdfjs/content/build/pdf.mjs | 74 ++++++-
toolkit/components/pdfjs/content/build/pdf.scripting.mjs | 4 +-
toolkit/components/pdfjs/content/build/pdf.worker.mjs | 102 +++++----
toolkit/components/pdfjs/content/web/viewer-geckoview.mjs | 80 +++---
toolkit/components/pdfjs/content/web/viewer.css | 9 +
toolkit/components/pdfjs/content/web/viewer.mjs | 98 +++++----
toolkit/components/pdfjs/moz.yaml | 4 +-
9 files changed, 223 insertions(+), 151 deletions(-)

---

5ae936eb87771d64e896f38a3ed5ef5463a58f4b by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/commit/5ae936eb87771d64e896f38a3ed5ef5463a58f4b
Authored: 2024-06-13 22:03:18 +0200
Committed: 2024-06-13 22:54:52 +0200

Display a wait cursor when saving

When the document is a bit long to save (for example in modifying a large document)
we must have something indicating that pdf.js is doing something.

Files Modified:

• web/app.js
• web/viewer.css

---

ff6180a4c94dd35c2c2e3c39f0a06835d3fe2ee6 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/commit/ff6180a4c94dd35c2c2e3c39f0a06835d3fe2ee6
Authored: 2024-06-12 12:51:51 +0200
Committed: 2024-06-12 18:41:07 +0200

Add an option to enable/disable hardware acceleration (bug 1902012)

Files Modified:

• extensions/chromium/preferences_schema.json
• src/core/default_appearance.js
• src/display/api.js
• src/display/base_factory.js
• src/display/display_utils.js
• src/display/editor/tools.js
• src/display/text_layer.js
• web/app.js
• web/app_options.js
• web/pdf_page_view.js
• web/pdf_thumbnail_view.js
• web/pdf_thumbnail_viewer.js
• web/pdf_viewer.js

---

42999e5bef256e15aaf73750cc31707783ba830a by Jonas Jenwald <[e-mail]>

https://github.com/mozilla/pdf.js/commit/42999e5bef256e15aaf73750cc31707783ba830a
Authored: 2024-06-12 13:21:33 +0200
Committed: 2024-06-12 13:27:45 +0200

Remove the DownloadManager.downloadUrl method

This method has only a single call-site in the viewer, since it's used as a fallback, and the functionality can be moved into the DownloadManager.download method instead.

Files Modified:

• web/app.js
• web/download_manager.js
• web/firefoxcom.js
• web/interfaces.js

---

e0a01328f361bf981e6bde0e1831ede0001cac17 by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/commit/e0a01328f361bf981e6bde0e1831ede0001cac17
Authored: 2024-06-11 15:13:06 +0200
Committed: 2024-06-11 15:13:06 +0200

Update translations to the most recent versions

Files Modified:

• l10n/br/viewer.ftl
• l10n/kab/viewer.ftl
• l10n/nn-NO/viewer.ftl

---

8273dcaa81790a4bb1008c945c17fe3d694aae8a by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/commit/8273dcaa81790a4bb1008c945c17fe3d694aae8a
Authored: 2024-06-11 15:11:07 +0200
Committed: 2024-06-11 15:11:07 +0200

Fix vulnerabilities in dependency versions

This patch is generated automatically using npm audit fix.

Files Modified:

• package-lock.json

---

866b9482261d8de435fcda65f4b4db65945a94f3 by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/commit/866b9482261d8de435fcda65f4b4db65945a94f3
Authored: 2024-06-11 15:08:55 +0200
Committed: 2024-06-11 15:10:22 +0200

Update dependencies to the most recent versions

Files Modified:

• package-lock.json
• package.json

---

e3faa40f0fabe52b3a2b82464775ec09c2840f03 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/commit/e3faa40f0fabe52b3a2b82464775ec09c2840f03
Authored: 2024-06-10 19:25:26 +0200
Committed: 2024-06-10 21:01:37 +0200

Don't display annotations with a PMD (barcode stuff) entry (bug 1899804)

There's no specification for that (even if it's possible to have an idea from
the xfa specs) so we just want to hide them in order to avoid to display something
wrong.

Files Added:

• test/pdfs/bug1899804.pdf.link

Files Modified:

• src/core/annotation.js
• test/test_manifest.json

---

61398066b99749dc76620deba0f2bcf80fac38ab by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/commit/61398066b99749dc76620deba0f2bcf80fac38ab
Authored: 2024-06-07 16:02:25 +0200
Committed: 2024-06-07 17:38:35 +0200

Update our OpenJPEG decoder in order to fix a malloc failure due to big image (bug 1901253)

It has been fixed in:
https://github.com/mozilla/pdf.js.openjpeg/commit/5ef68089b5349aca9fe735e961cb396e47a3c30f

Files Added:

• test/pdfs/bug1901253.pdf.link

Files Modified:

• external/openjpeg/openjpeg.js
• test/test_manifest.json

---

412e03e576fc7f91fd1c9457d56386b0297c6fd2 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/commit/412e03e576fc7f91fd1c9457d56386b0297c6fd2
Authored: 2024-06-06 21:32:20 +0200
Committed: 2024-06-07 14:26:01 +0200

[Editor] Support dragging & dropping images on a pdf (bug 1900907)

Files Modified:

• src/display/editor/tools.js
• web/app.js

---

f7cbd7d16b46c79af37484248af772a704063da1 by Jonas Jenwald <[e-mail]>

https://github.com/mozilla/pdf.js/commit/f7cbd7d16b46c79af37484248af772a704063da1
Authored: 2024-06-07 13:28:25 +0200
Committed: 2024-06-07 13:32:28 +0200

Inline the #finishRendering helper in TextLayerBuilder.prototype.render

This helper method is simpler/shorter than it originally was[1] and with recent refactoring so is the render-method, hence we can just inline this code now.

---

[1] It used to e.g. dispatch the "textlayerrendered" event.

Files Modified:

• web/text_layer_builder.js

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=4e4db112b2ea84d2c6868e637dd13e9911dd2a4c

Comment 2

[Update Bot]

Attachment: Bug 1902649 - Update PDF.js to e3caa3c6eeda90099dd03b451b6b4788746455b3 r=#pdfjs-reviewers

Comment 3

[Update Bot]

All the jobs in the try run succeeded. Like literally all of them, there weren't
even any intermittents. That is pretty surprising to me, so maybe you should double
check to make sure I didn't misinterpret things and that the correct tests ran...

Anyway, I've done all I can, so I'm passing to you to review and land the patch.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/717431608191
Update PDF.js to e3caa3c6eeda90099dd03b451b6b4788746455b3 r=pdfjs-reviewers,robwu

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/717431608191