1902674 - The radio buttons in moz-radio are misaligned on Windows

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Tim Giles [:tgiles]]

Due to HTML input elements on Windows using the "MS Shell Dlg 2" virtual font and our styles using lh, the radio buttons are slightly misaligned on Windows. This can easily be fixed by using font-family: inherit in the input styles for this component.

Comment 1

[Tim Giles [:tgiles]]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • Here is a more detailed tutorial for getting set up to work on Firefox
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
3. Start working on this bug.
   • You will need to add font-family: inherit in this input selector rule
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #reusable-components channel on Element/Matrix most hours of most days.
4. Build your change with mach build and test your change with mach storybook and checking the alignment in the radio story. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 2

[Anand Roy [:aroy]]

Attachment: Bug 1902674 - Fix alignment of radio buttons in moz-radio button on Windows. r=tgiles

Comment 3

[Anand Roy [:aroy]]

Hi Tim, please review my patch

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8a10f964358
Fix alignment of radio buttons in moz-radio button on Windows. r=tgiles,reusable-components-reviewers

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f8a10f964358