1902682 - Rename category-discover.svg potentially to insights-20

Status: NEW

(Firefox :: Theme, task)

Description

[Ed Lee :Mardak]

Bug 1899827 was about to add browser/themes/shared/icons/insights.svg but turns out it's a 16px version of 20px https://searchfox.org/mozilla-central/source/toolkit/themes/shared/extensions/category-discover.svg so I switched to using the existing.

https://phabricator.services.mozilla.com/D212756?id=872793#inline-1183833

This looks like a 16px version of toolkit/themes/shared/extensions/category-discover.svg. I'm not sure which needs renaming, but these should be linked.

I'd guess category-discover.svg needs to be insights-20.svg, but I have a vague memory of a discussion about the 'category' name that resulted in us leaving it as-is. Could you file a follow-up bug so we don't lose track of this?

Comment 1

[Ed Lee :Mardak]

Looks like what landed as category-overview.svg in bug 1843603 then renamed to category-recentbrowsing.svg and now view-recentbrowsing.svg with bug 1850591 is the same sparkles icon too.

Additionally there was some previous deduping of this icon as part of bug 1708502 with highlights.svg used by various places including newtab / firefox home, urlbar cfr, more(??)

Comment 2

[Ed Lee :Mardak]

Attachment: sparkles everywhere.png

Comment 3

[Itiel]

I'd rather name it as what it is (sparkle-20.svg) and not what it conveys (highlight-20/insights-20 etc), since for different contexts an icon may have different connotation, especially for icons that are kind of vague such as this one.