1902829 - Perma release-simulation decision task filter_out_android_on_esr() missing 1 required positional argument: 'task'

Status: VERIFIED FIXED

(Firefox Build System :: Task Configuration, defect)

Description

[Narcis Beleuzu [:NarcisB]]

[Tracking Requested - why for this release]:

Central-as-beta-simulation

How to run these simulations

Failure log

Log snippet:

[task 2024-06-15T09:57:12.031Z] Generating target task set
[task 2024-06-15T09:57:12.038Z] Traceback (most recent call last):
[task 2024-06-15T09:57:12.038Z]   File "/builds/worker/checkouts/gecko/taskcluster/mach_commands.py", line 209, in taskgraph_decision
[task 2024-06-15T09:57:12.038Z]     ret = taskgraph_commands["decision"].func(options)
[task 2024-06-15T09:57:12.038Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/main.py", line 703, in decision
[task 2024-06-15T09:57:12.038Z]     taskgraph_decision(options)
[task 2024-06-15T09:57:12.038Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/decision.py", line 223, in taskgraph_decision
[task 2024-06-15T09:57:12.038Z]     write_artifact("target-tasks.json", list(tgg.target_task_set.tasks.keys()))
[task 2024-06-15T09:57:12.038Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/generator.py", line 179, in target_task_set
[task 2024-06-15T09:57:12.038Z]     return self._run_until("target_task_set")
[task 2024-06-15T09:57:12.038Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/generator.py", line 425, in _run_until
[task 2024-06-15T09:57:12.038Z]     k, v = next(self._run)
[task 2024-06-15T09:57:12.038Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/generator.py", line 350, in _run
[task 2024-06-15T09:57:12.038Z]     target_tasks = set(fltr(target_task_set, parameters, graph_config))
[task 2024-06-15T09:57:12.038Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/filter_tasks.py", line 34, in filter_target_tasks
[task 2024-06-15T09:57:12.038Z]     return fn(graph, parameters, graph_config)
[task 2024-06-15T09:57:12.038Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/target_tasks.py", line 1270, in target_tasks_release_simulation
[task 2024-06-15T09:57:12.038Z]     return [
[task 2024-06-15T09:57:12.038Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/target_tasks.py", line 1276, in <listcomp>
[task 2024-06-15T09:57:12.038Z]     and filter_out_android_on_esr(t)
[task 2024-06-15T09:57:12.038Z] TypeError: filter_out_android_on_esr() missing 1 required positional argument: 'task'

Julien, can you please take a look?

Comment 1

[Julien Cristau [:jcristau]]

Attachment: Bug 1902829 - fix release_simulation target tasks method.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d00c580fa44d
fix release_simulation target tasks method.

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d00c580fa44d

Comment 4

[Cristian Tuns]

The patch is working in today's beta-simulation: https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&revision=af656c05a066c85075596b83ccc97027f6789c15&selectedTaskRun=XMM_zoQ9QOCw7hreRoDMog.0&searchStr=Gecko%2CDecision%2CTask%2Copt%2CGecko%2CDecision%2CTask%2CD