1902859 - Improve Select Translations Multi-Locale Preferred Language Tests

Status: RESOLVED FIXED

(Firefox :: Translations, task, P3)

Description

[Erik Nordin [:nordzilla]]

Description

When writing Bug 1902711 I tried to add extra testing around multi-locale preferred language tests for opening the context menu to translate selected text. Things worked pretty well locally, but ran into issues in CI with the Intl.DisplayNames not matching the mocked locale.

I believe that all the functionality is correct (the underlying functions are tested), but I would still like to have integration tests for this.

We should consider adding the current language tag to the translate-selection context menu item so that we can deterministically tell which language has been offered without having to worry about the language's display from mocked locale test infrastructure.

---

Steps to implement

• Invesitgate storing the currently offered language tag as an attribute on the translate-selection context menu item, that way we can test with the language tag rather than the display name.

---

Tests to implement

• Rework the tests to compare against the language tag, rather than the display name.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1902859 - Add multi-locale context menu tests r=#translations-reviewers!,gregtatum

Adds several test cases to test the SelectTranslations
context-menu offering with various locale and web content
languages.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/886936954825
Add multi-locale context menu tests r=translations-reviewers,ohall,gregtatum

Comment 3

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/886936954825