190288 - Call order of pref data extraction and OK handlers switched

Status: RESOLVED WONTFIX

(SeaMonkey :: Preferences, defect)

Description

[jag (Peter Annema)]

From bug 89907:

------- Additional Comment #93 From Anatoliy Averbukh  2002-09-04 11:37 -------

Part of this patch caused problem (file nsPrefWindow.js): it changed order in 
which pref values are extracted and call back functions are executed.

Before, the call back functions are executed first and then the values are 
extracted, the patch changed the order, it leads to serious regressions for 
applications.

Reopenning the bug.


------- Additional Comment #94 From Anatoliy Averbukh 2002-09-18 14:31 -------

Is somebody going to do something with this bug?


---------------------------------

I think there's something to be said for either call order. You can use the
GetFields and SetFields call-back functions to hand back pref values for the
prefs that need special attention, and then use the OK handler for tweaking of
the pageData object (current order). On the other hand, you could use the OK
handler to tweak attribute values on the elements before GetFields is called or
the pref values collector walks the document.

Ben, Bill, do either of you remember the reason for the change made in
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsPrefWindow.js&root=/cvsroot&subdir=mozilla/xpfe/components/prefwindow/resources/content&command=DIFF_FRAMESET&rev1=1.37&rev2=1.38
?

Anatoliy Averbukh, do you have specific examples (or a complete list) of what
broke because of this change? I'd like to know what to fix if this change was
intentional and desired.

Comment 1

[Anatoliy Averbukh]

It affected IM/ICQ preferences. Unfortunatly they were designed the way, when 
the order is important.

Comment 2

[Serge Gautherie (:sgautherie)]

(Filter "spam" on 'prefs-nobody-20080612'.)

Comment 3

[Philip Chee]

nsPrefWindow is obsolete since the move to toolkit preferences system and will
be hg removed RSN. If this issue still exists please file a new bug against the new toolkitized prefwindow.