1902961 - DevTools incorrectly reports that element with `float:left;display:inline-grid` has been changed to block

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Daniel Holbert [:dholbert]]

Attachment: testcase 1

STR:

1. Load attached testcase.
2. Open at the Rules View in DevTools Inspector, with the testcase's sole div selected.
3. Hover the circled "i" next to the grayed-out display:inline-grid rule.

ACTUAL RESULTS:
There's a tooltip saying: "The display value has been changed by the engine to block because the element is floated. Try removing float or adding display:block"

This is not correct; in fact the display value has been changed to grid, not to block. (It's been "blockified" which means inline --> block and inline-$X --> $X).

EXPECTED RESULTS:
The message should say "grid" instead of "block". Or if we want to keep things generic, we could rewrite the message to say "the block-level equivalent" instead of "block".

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot

Comment 2

[Julian Descottes [:jdescottes]]

Thanks! We should get the computed display value and use this instead.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1902961 - [devtools] Include proper computed display value in inactive-css-not-display-block-on-floated message. r=#devtools-reviewers.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a8c20f23fcf
[devtools] Include proper computed display value in inactive-css-not-display-block-on-floated message. r=devtools-reviewers,fluent-reviewers,ochameau.

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6a8c20f23fcf