1903116 - Android: Consider increasing the number of sockets available for speculative connect (currently 6)

Status: RESOLVED FIXED

(Core :: Networking, task, P3)

Description

[Andrew Creskey [:acreskey]]

In Bug 1816539 we measured improvements by increasing the number of sockets available for speculative connections on desktop.
Let's see if we can improve things on the Android side (note that we have a smaller overall socket pool)

Comment 1

[Andrew Creskey [:acreskey]]

Markus has found an interesting case where we seem to be getting conflicting reports on how the defined limit is used

This profile, https://share.firefox.dev/3HgLOky, has the limit increased from 6 to 10, https://hg-edge.mozilla.org/try/rev/f7946f9501ffbeee6678f6875e258f929c645869

Although we see logs with the limit of 6 referenced

LogMessages — (nsHttp) DoSpeculativeConnectionInternal Transport ci=.S........[tlsflags0x00000000]shell--mozilla-speedometer-preview.netlify.app:443^partitionKey=%28https%2Cshell--mozilla-speedometer-preview.netlify.app%29 not created due to existing connection count:6

And the main thread gets 10 from the preference
https://share.firefox.dev/43DVyN4

So we'll need to sort that out to fix this.

Comment 2

[Andrew Creskey [:acreskey]]

I'm seeing the preference being respected in my tests, so far.

LogMessages — (nsHttp) DoSpeculativeConnectionInternal Transport ci=.SA...C...[tlsflags0x00000000]incoming.telemetry.mozilla.org:443 not created due to existing connection count:20

We do have telemetry to track the outcomes, Glam with about 13% success rate and 87% failure due to limits.

This aborted_socket_limit "not created due to existing connection count" outcome is recorded here although I don't think it perfectly captures what we want, as the conditions for triggering it are a bit more complicated.

In bug 1889771 we increased the max number of sockets on android to 128, but we did not increase the size of the pool available for speculative connections.

Given that most of the speculative connections come from the necko runtime, it seems reasonable to me to remove the android-specific limit and monitor telemetry to look for impact?

Comment 3

[Andrew Creskey [:acreskey]]

Attachment: Bug 1903116 - Android: Consider increasing the number of sockets available for speculative connect (currently 6) r=#necko-reviewers

In bug 1889771 we increased the max number of sockets on android to 128, but we did not increase the size of the pool available for speculative connections.
Removing the android-specific limit and will monitor telemetry to look for impact.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/188fc804f192
https://hg.mozilla.org/integration/autoland/rev/394eede9b3ec
Android: Consider increasing the number of sockets available for speculative connect (currently 6) r=necko-reviewers,valentin

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/394eede9b3ec