1903158 - Reference count error in nsImapService::FetchMessage

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Geoff Lankow (:darktrojan)]

nsImapService::FetchMessage has one code path where references to aURL are added twice, leaving one when the object is finished with and causing it to leak.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1903158 - Fix double AddRef in nsImapService::FetchMessage. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/50a1b0bf9022
Fix double AddRef in nsImapService::FetchMessage. r=mkmelin

Comment 3

[Geoff Lankow (:darktrojan)]

Thinking about it some more, the commit message is slightly inaccurate. We're not counting the reference to the pointer at aURL twice, we're creating a second pointer in the same place, without cleaning up the first one.

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9408041 [details]
Bug 1903158 - Fix double AddRef in nsImapService::FetchMessage. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: memory leak
Testing completed (on c-c, etc.): this only landed yesterday but we're unlikely to get any feedback on it - can confirm it fixes the leak
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Corey Bryant]

Comment on attachment 9408041 [details]
Bug 1903158 - Fix double AddRef in nsImapService::FetchMessage. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 6

[Daniel Darnell [:dandarnell]]

Thunderbird 128.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/11c24029dfaa