1903191 - Firefox doesn't allow radio buttons to be literally zero sized

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: radio.html

STR:

1. Load attached testcase.

ACTUAL RESULTS:
The bottom 4 rows, "4" through "0", are all the same size.

EXPECTED RESULTS:
They should be progressively smaller, with 0 being completely invisible.

This is the root cause of bug 1900326 where a site is depending on a radio button with width:0; height:0 to not-contirbute-at-all to scrollable overflow. The fact that it contributes creates a giant scrollable area that the site does not actually want to be present. If we let it be zero sized, then it wouldn't contribute to scrollable overflow and everything would be fine.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot of Gecko, WebKit, Chromium (with red box around the buttons that aren't honoring specified size)

Comment 2

[Emilio Cobos Álvarez (:emilio)]

That's because we enforce a border here. I think we can try not to, but we might have to fix up the baselines.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1903191 - Tweak sizing to allow zero-size checkboxes/radio buttons. r=dholbert,#layout

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c34c76566d2
Tweak sizing to allow zero-size checkboxes/radio buttons. r=dholbert

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46827 for changes under testing/web-platform/tests

Comment 6

[Aron Cseh]

Backed out for causing assertion failures on nsCheckboxRadioFrame.cpp

• Backout link
• Push with failures
• Failure Log

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60441f245287
Tweak sizing to allow zero-size checkboxes/radio buttons. r=dholbert

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/60441f245287

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-06-17 Nightly build on Windows 10.
Verified as fixed on Firefox 129.0b2 and Firefox Nightly 130.0a1 on Windows 10, Ubuntu 22, macOS 14.

Comment 13

[Donal Meehan [:dmeehan]]

Backed out of beta for causing Bug 1907291
https://hg.mozilla.org/releases/mozilla-beta/rev/665b557e059d62c46ea8253e1c50a1deaa0d6d3e